Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(infrastructure): add declaration package.json #572

Merged
merged 2 commits into from
Dec 28, 2018

Conversation

moog16
Copy link

@moog16 moog16 commented Dec 28, 2018

fixes #567

@moog16 moog16 added this to the 0.8.0 milestone Dec 28, 2018
@moog16 moog16 changed the base branch from master to rc0.8.0 December 28, 2018 02:47
@googlebot
Copy link

So there's good news and bad news.

👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there.

😕 The bad news is that it appears that one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that here in the pull request.

Note to project maintainer: This is a terminal state, meaning the cla/google commit status will not change from this state. It's up to you to confirm consent of all the commit author(s), set the cla label to yes (if enabled on your project), and then merge this pull request when appropriate.

@googlebot
Copy link

CLAs look good, thanks!

@codecov-io
Copy link

Codecov Report

Merging #572 into rc0.8.0 will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           rc0.8.0     #572   +/-   ##
========================================
  Coverage    94.71%   94.71%           
========================================
  Files           61       61           
  Lines         2554     2554           
  Branches       365      365           
========================================
  Hits          2419     2419           
  Misses          50       50           
  Partials        85       85

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f95a3e8...ec160fa. Read the comment docs.

Copy link
Contributor

@williamernest williamernest left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@moog16 moog16 merged commit 989b206 into rc0.8.0 Dec 28, 2018
@moog16 moog16 deleted the fix/add-declaration-package-son branch December 28, 2018 18:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants