docs: outside contributions #441
Conversation
|
So there's good news and bad news. 👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there. 😕 The bad news is that it appears that one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that here in the pull request. Note to project maintainer: This is a terminal state, meaning the |
|
CLAs look good, thanks! |
Codecov Report
@@ Coverage Diff @@
## rc7.0 #441 +/- ##
=======================================
Coverage 96.29% 96.29%
=======================================
Files 56 56
Lines 1914 1914
Branches 228 228
=======================================
Hits 1843 1843
Misses 71 71Continue to review full report at Codecov.
|
docs/contributions/README.md
Outdated
|
|
||
| ### Process | ||
|
|
||
| Before opening a PR, it should be up to date with targeted release (rc<release_number> ie. rc7.0, rc8.0, etc.). In most cases it will never be branched from _master_. |
There was a problem hiding this comment.
We should add 0. in front of the versions in the branch name moving forward, like rc0.7.0, rc0.8.0.
So it's not confusing if we ever release 1.0.0 lol 😱
There was a problem hiding this comment.
ya true - just thought it was easier to type lol
docs/contributions/README.md
Outdated
|
|
||
| ``` | ||
| # for a fix to an issue | ||
| fix(foo): Short description of fix |
There was a problem hiding this comment.
Replace foo with component-name. Here and 2 below
|
|
||
| Please refer to [screenshot tests](../screnshot-tests.md). | ||
|
|
||
| ## Unit Tests |
There was a problem hiding this comment.
Add a section for running lint. Or include a note at the top that tells people to just run npm test for all tests
fixes #440