Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(list): Refactor list item management #413

Merged
merged 28 commits into from
Nov 6, 2018
Merged

refactor(list): Refactor list item management #413

merged 28 commits into from
Nov 6, 2018

Commits on Oct 30, 2018

  1. WIP refactor

    @bonniezhou
    bonniezhou committed Oct 30, 2018
    Configuration menu
    Copy the full SHA
    2398167 View commit details
    Browse the repository at this point in the history

  2. more WIP

    @bonniezhou
    bonniezhou committed Oct 30, 2018
    Configuration menu
    Copy the full SHA
    10e0618 View commit details
    Browse the repository at this point in the history

Commits on Oct 31, 2018

  1. WIP listItemPropUpdates state var

    @bonniezhou
    bonniezhou committed Oct 31, 2018
    Configuration menu
    Copy the full SHA
    685eda0 View commit details
    Browse the repository at this point in the history

  2. WIP split up state vars again

    @bonniezhou
    bonniezhou committed Oct 31, 2018
    Configuration menu
    Copy the full SHA
    833e7f7 View commit details
    Browse the repository at this point in the history

  3. omg it works

    @bonniezhou
    bonniezhou committed Oct 31, 2018
    Configuration menu
    Copy the full SHA
    e7c6ce0 View commit details
    Browse the repository at this point in the history

  4. make it work with dividers

    @bonniezhou
    bonniezhou committed Oct 31, 2018
    Configuration menu
    Copy the full SHA
    2f86c3b View commit details
    Browse the repository at this point in the history

Commits on Nov 5, 2018

  1. add inserting list items to screenshot test

    @bonniezhou
    bonniezhou committed Nov 5, 2018
    Configuration menu
    Copy the full SHA
    0f01fa7 View commit details
    Browse the repository at this point in the history

  2. TESTS

    @bonniezhou
    bonniezhou committed Nov 5, 2018
    Configuration menu
    Copy the full SHA
    3ada718 View commit details
    Browse the repository at this point in the history

  3. lint

    @bonniezhou
    bonniezhou committed Nov 5, 2018
    Configuration menu
    Copy the full SHA
    cc3a0bc View commit details
    Browse the repository at this point in the history

  4. Merge branch 'master' into refactor/list-item-logic

    @bonniezhou
    bonniezhou authored Nov 5, 2018
    Configuration menu
    Copy the full SHA
    96df39d View commit details
    Browse the repository at this point in the history

  5. npm run capture

    @bonniezhou
    bonniezhou committed Nov 5, 2018
    Configuration menu
    Copy the full SHA
    742ffa5 View commit details
    Browse the repository at this point in the history

  6. revert non list golden changes

    @bonniezhou
    bonniezhou committed Nov 5, 2018
    Configuration menu
    Copy the full SHA
    6e66262 View commit details
    Browse the repository at this point in the history

  7. fix test

    @bonniezhou
    bonniezhou committed Nov 5, 2018
    Configuration menu
    Copy the full SHA
    768cb4f View commit details
    Browse the repository at this point in the history

  8. add handleSelect

    @bonniezhou
    bonniezhou committed Nov 5, 2018
    Configuration menu
    Copy the full SHA
    a8bce9d View commit details
    Browse the repository at this point in the history

  9. Merge branch 'master' into refactor/list-item-logic

    @bonniezhou
    bonniezhou authored Nov 5, 2018
    Configuration menu
    Copy the full SHA
    2ab5e30 View commit details
    Browse the repository at this point in the history

  10. update for comments

    @bonniezhou
    bonniezhou committed Nov 5, 2018
    Configuration menu
    Copy the full SHA
    f1bb2a1 View commit details
    Browse the repository at this point in the history

  11. merge with master

    @bonniezhou
    bonniezhou committed Nov 5, 2018
    Configuration menu
    Copy the full SHA
    d373744 View commit details
    Browse the repository at this point in the history

  12. lint

    @bonniezhou
    bonniezhou committed Nov 5, 2018
    Configuration menu
    Copy the full SHA
    9de4c28 View commit details
    Browse the repository at this point in the history

Commits on Nov 6, 2018

  1. update golden

    @bonniezhou
    bonniezhou committed Nov 6, 2018
    Configuration menu
    Copy the full SHA
    87231ce View commit details
    Browse the repository at this point in the history

  2. revert golden for not list

    @bonniezhou
    bonniezhou committed Nov 6, 2018
    Configuration menu
    Copy the full SHA
    a972255 View commit details
    Browse the repository at this point in the history

  3. remove .only from tet

    @bonniezhou
    bonniezhou committed Nov 6, 2018
    Configuration menu
    Copy the full SHA
    b3afed1 View commit details
    Browse the repository at this point in the history

  4. update for comments

    @bonniezhou
    bonniezhou committed Nov 6, 2018
    Configuration menu
    Copy the full SHA
    9d5a3ea View commit details
    Browse the repository at this point in the history

  5. fix some tests

    @bonniezhou
    bonniezhou committed Nov 6, 2018
    Configuration menu
    Copy the full SHA
    88c0907 View commit details
    Browse the repository at this point in the history

  6. fix list group prop

    @bonniezhou
    bonniezhou committed Nov 6, 2018
    Configuration menu
    Copy the full SHA
    9374018 View commit details
    Browse the repository at this point in the history

  7. Merge branch 'master' into refactor/list-item-logic

    @bonniezhou
    bonniezhou authored Nov 6, 2018
    Configuration menu
    Copy the full SHA
    15e59f2 View commit details
    Browse the repository at this point in the history

  8. getFocusedElementIndex

    @bonniezhou
    bonniezhou committed Nov 6, 2018
    Configuration menu
    Copy the full SHA
    48e6704 View commit details
    Browse the repository at this point in the history

  9. merge with masteR

    @bonniezhou
    bonniezhou committed Nov 6, 2018
    Configuration menu
    Copy the full SHA
    09b14c2 View commit details
    Browse the repository at this point in the history

  10. readme

    @bonniezhou
    bonniezhou committed Nov 6, 2018
    Configuration menu
    Copy the full SHA
    fbc15f1 View commit details
    Browse the repository at this point in the history