Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TEST Simsim0709 fix/textfield/style prop DO NOT MERGE #204

Closed
wants to merge 7 commits into from

Conversation

moog16
Copy link

@moog16 moog16 commented Aug 3, 2018

Tests for #184

simsim0709 and others added 4 commits July 28, 2018 12:34
TextField component is not passing `otherProps`, because of that we cannot use style prop.
It seems like it's your intention not passing `otherProps` to the root element, so I have explicitly added `style` prop.
@googlebot
Copy link

So there's good news and bad news.

👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there.

😕 The bad news is that it appears that one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that here in the pull request.

Note to project maintainer: This is a terminal state, meaning the cla/google commit status will not change from this state. It's up to you to confirm consent of the commit author(s) and merge this pull request when appropriate.

@codecov-io
Copy link

codecov-io commented Aug 3, 2018

Codecov Report

Merging #204 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #204      +/-   ##
==========================================
+ Coverage   98.78%   98.78%   +<.01%     
==========================================
  Files          21       21              
  Lines         821      824       +3     
  Branches       76       76              
==========================================
+ Hits          811      814       +3     
  Misses         10       10
Impacted Files Coverage Δ
packages/text-field/index.js 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e9a2089...2836d3a. Read the comment docs.

@moog16 moog16 closed this Aug 8, 2018
@moog16 moog16 deleted the simsim0709-fix/textfield/style-prop branch August 8, 2018 21:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants