Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wesleyabbey feat/button semantic #176

Closed
wants to merge 8 commits into from

Conversation

moog16
Copy link

@moog16 moog16 commented Jul 25, 2018

TESTS: DO NOT MERGE

related #174

Wesley Abbey and others added 6 commits July 24, 2018 22:24
Adding a new href prop. This href prop will automatically convert the button into an anchor tag.
…l-components-web-react into feat/button-semantic
@googlebot
Copy link

So there's good news and bad news.

👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there.

😕 The bad news is that it appears that one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that here in the pull request.

Note to project maintainer: This is a terminal state, meaning the cla/google commit status will not change from this state. It's up to you to confirm consent of the commit author(s) and merge this pull request when appropriate.

@codecov-io
Copy link

codecov-io commented Jul 25, 2018

Codecov Report

Merging #176 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #176      +/-   ##
==========================================
+ Coverage   95.82%   95.82%   +<.01%     
==========================================
  Files          21       21              
  Lines         718      719       +1     
  Branches       66       67       +1     
==========================================
+ Hits          688      689       +1     
  Misses         30       30
Impacted Files Coverage Δ
packages/button/index.js 93.33% <100%> (+0.47%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b45b55c...1a79255. Read the comment docs.

@moog16
Copy link
Author

moog16 commented Jul 25, 2018

Closing #174 merged

@moog16 moog16 closed this Jul 25, 2018
@moog16 moog16 deleted the wesleyabbey-feat/button-semantic branch September 20, 2018 00:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants