-
Notifications
You must be signed in to change notification settings - Fork 227
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(tab): Allow to render Tab as an anchor node #928
feat(tab): Allow to render Tab as an anchor node #928
Conversation
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here (e.g. What to do if you already signed the CLAIndividual signers
Corporate signers
ℹ️ Googlers: Go here for more info. |
I signed it! |
CLAs look good, thanks! ℹ️ Googlers: Go here for more info. |
Codecov Report
@@ Coverage Diff @@
## rc0.14.0 #928 +/- ##
============================================
+ Coverage 94.08% 94.08% +<.01%
============================================
Files 86 86
Lines 3636 3637 +1
Branches 573 573
============================================
+ Hits 3421 3422 +1
Misses 90 90
Partials 125 125
Continue to review full report at Codecov.
|
not sure why the build failed for me, the failed tests does not seem to be related with my change, but probably they are, I will try to find out why |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please update base branch to be rc0.14.0. thanks!
@barteksekula I tried running the screenshot tests (npm start). There are a lot of TS errors resulting in the screenshot tests failing. Can you please take a look? |
@moog16 it's strange because I'm not getting any ts errors after running npm start. |
@barteksekula this shouldn't be affecting the other screenshot tests. I don't think it should even affect the tab component. I'll look into this. |
Can you please make sure you are up to date on the latest rc0.14.0 branch? |
So there's good news and bad news. 👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there. 😕 The bad news is that it appears that one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that here in the pull request. Note to project maintainer: This is a terminal state, meaning the ℹ️ Googlers: Go here for more info. |
CLAs look good, thanks! ℹ️ Googlers: Go here for more info. |
@moog16 great, I rebased and now it's all green. thanks! :) |
Great! Thanks :) |
Thanks for your contribution! |
No description provided.