-
Notifications
You must be signed in to change notification settings - Fork 227
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(infrastructure): build JS from TS #547
Conversation
This reverts commit d486cef.
Codecov Report
@@ Coverage Diff @@
## feat/two-typescript #547 +/- ##
====================================================
Coverage 97.74% 97.74%
====================================================
Files 60 60
Lines 2127 2127
Branches 65 65
====================================================
Hits 2079 2079
Misses 36 36
Partials 12 12
Continue to review full report at Codecov.
|
It smells that these files are being imported from a particular path in the file system ( |
This is a pattern is going to be fixed in a later release. MDC Web started pointing to the /dist/... files after 0.42.0. Currently React is pointing at 0.41.1. We point to the /dist/... because we don't transpile the node_modules, which can lead to unintended consequences if people are expecting ES5 |
So there's good news and bad news. 👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there. 😕 The bad news is that it appears that one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that here in the pull request. Note to project maintainer: This is a terminal state, meaning the |
Did you make a bug for removing |
it exists #183 |
tests passing, CLA was already met. Merging |
Builds TSX files into ES5 and .d.ts typings files.