Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(infrastructure): build JS from TS #547

Merged
merged 105 commits into from
Dec 20, 2018

Conversation

moog16
Copy link

@moog16 moog16 commented Dec 19, 2018

Builds TSX files into ES5 and .d.ts typings files.

@codecov-io
Copy link

codecov-io commented Dec 19, 2018

Codecov Report

Merging #547 into feat/two-typescript will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@                 Coverage Diff                  @@
##           feat/two-typescript     #547   +/-   ##
====================================================
  Coverage                97.74%   97.74%           
====================================================
  Files                       60       60           
  Lines                     2127     2127           
  Branches                    65       65           
====================================================
  Hits                      2079     2079           
  Misses                      36       36           
  Partials                    12       12
Impacted Files Coverage Δ
packages/text-field/Input.tsx 96.72% <ø> (ø) ⬆️
packages/line-ripple/index.tsx 100% <100%> (ø) ⬆️
packages/text-field/icon/index.tsx 100% <100%> (ø) ⬆️
packages/floating-label/index.tsx 100% <100%> (ø) ⬆️
packages/text-field/helper-text/index.tsx 100% <100%> (ø) ⬆️
packages/text-field/index.tsx 98.11% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 226ce29...cfcd724. Read the comment docs.

@appsforartists
Copy link

It smells that these files are being imported from a particular path in the file system (/dist/…). I see that there in a similar pattern already committed, but why can't you import {MDCFloatingLabelFoundation} from '@material/floating-label?

@moog16
Copy link
Author

moog16 commented Dec 19, 2018

This is a pattern is going to be fixed in a later release. MDC Web started pointing to the /dist/... files after 0.42.0. Currently React is pointing at 0.41.1. We point to the /dist/... because we don't transpile the node_modules, which can lead to unintended consequences if people are expecting ES5

@moog16 moog16 changed the base branch from fix/coverage-typescript to feat/two-typescript December 19, 2018 23:59
@googlebot
Copy link

So there's good news and bad news.

👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there.

😕 The bad news is that it appears that one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that here in the pull request.

Note to project maintainer: This is a terminal state, meaning the cla/google commit status will not change from this state. It's up to you to confirm consent of all the commit author(s), set the cla label to yes (if enabled on your project), and then merge this pull request when appropriate.

@appsforartists
Copy link

Did you make a bug for removing dist?

@moog16
Copy link
Author

moog16 commented Dec 20, 2018

it exists #183

@moog16
Copy link
Author

moog16 commented Dec 20, 2018

tests passing, CLA was already met. Merging

@moog16 moog16 merged commit 740c467 into feat/two-typescript Dec 20, 2018
@moog16 moog16 deleted the feat/build-js-from-ts branch December 20, 2018 02:33
moog16 pushed a commit that referenced this pull request Dec 27, 2018
moog16 pushed a commit that referenced this pull request Dec 28, 2018
moog16 pushed a commit that referenced this pull request Dec 28, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants