feat(icon-button): typescript support #496
Conversation
This reverts commit d486cef.
| import {MDCIconButtonToggleFoundation} from '@material/icon-button/dist/mdc.iconButton'; | ||
| import IconToggle from './IconToggle'; | ||
| const ARIA_PRESSED = 'aria-pressed'; |
There was a problem hiding this comment.
Why the change to set this directly instead of getting it from the foundation?
There was a problem hiding this comment.
TS compiler couldn't get it from the regular JS file.
test/unit/icon-button/index.test.tsx
Outdated
| import {IconButtonBase as IconButton} from '../../../packages/icon-button/index'; | ||
| import * as td from 'testdouble'; | ||
| import {shallow} from 'enzyme'; | ||
| // @ts-ignore |
moog16
changed the base branch from
fix/coverage-typescript
to
feat/two-typescript
|
So there's good news and bad news. 👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there. 😕 The bad news is that it appears that one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that here in the pull request. Note to project maintainer: This is a terminal state, meaning the |
related #48