-
Notifications
You must be signed in to change notification settings - Fork 227
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(button): Add an href prop #174
feat(button): Add an href prop #174
Conversation
Adding a new href prop. This href prop will automatically convert the button into an anchor tag.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@wesleyabbey thanks for opening the PR! Could you please add some unit tests
…l-components-web-react into feat/button-semantic
@wesleyabbey There should be a screenshot test case for this, but I'm pretty sure you cannot do that. I'll try adding it to this PR |
Running tests here: #176 @wesleyabbey since I don't have access to your branch, could you please add the code in this commit: |
Codecov Report
@@ Coverage Diff @@
## master #174 +/- ##
==========================================
+ Coverage 95.82% 95.82% +<.01%
==========================================
Files 21 21
Lines 718 719 +1
Branches 66 67 +1
==========================================
+ Hits 688 689 +1
Misses 30 30
Continue to review full report at Codecov.
|
I'm not sure why that test is failing. Is this an issue on my end? |
Not on your end. Its a known issue that we still need to work on. Since #176 passes and you have all the commits, this PR is ready to be merged. |
Thanks @wesleyabbey !! |
Adding a new href prop. This href prop will automatically convert the button into an anchor tag.
See issue #164