Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(button): Add an href prop #174

Merged
merged 7 commits into from
Jul 25, 2018

Conversation

wesleyabbey
Copy link
Contributor

@wesleyabbey wesleyabbey commented Jul 25, 2018

Adding a new href prop. This href prop will automatically convert the button into an anchor tag.

See issue #164

Wesley Abbey and others added 2 commits July 24, 2018 22:24
Adding a new href prop. This href prop will automatically convert the button into an anchor tag.
Copy link

@moog16 moog16 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@wesleyabbey thanks for opening the PR! Could you please add some unit tests

@moog16
Copy link

moog16 commented Jul 25, 2018

@wesleyabbey There should be a screenshot test case for this, but I'm pretty sure you cannot do that. I'll try adding it to this PR

@moog16
Copy link

moog16 commented Jul 25, 2018

Running tests here: #176

@wesleyabbey since I don't have access to your branch, could you please add the code in this commit:
e66d886

@codecov-io
Copy link

codecov-io commented Jul 25, 2018

Codecov Report

Merging #174 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #174      +/-   ##
==========================================
+ Coverage   95.82%   95.82%   +<.01%     
==========================================
  Files          21       21              
  Lines         718      719       +1     
  Branches       66       67       +1     
==========================================
+ Hits          688      689       +1     
  Misses         30       30
Impacted Files Coverage Δ
packages/button/index.js 93.33% <100%> (+0.47%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b45b55c...8ed8586. Read the comment docs.

@moog16
Copy link

moog16 commented Jul 25, 2018

almost there! we have screenshots and unit tests passing in #176.

Looks like there is a yarn.lock change - please remove changes.
Also please add this commit dae79c5

@wesleyabbey
Copy link
Contributor Author

I'm not sure why that test is failing. Is this an issue on my end?

@moog16
Copy link

moog16 commented Jul 25, 2018

Not on your end. Its a known issue that we still need to work on. Since #176 passes and you have all the commits, this PR is ready to be merged.

@moog16 moog16 merged commit 0df9967 into material-components:master Jul 25, 2018
@moog16
Copy link

moog16 commented Jul 25, 2018

Thanks @wesleyabbey !!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants