Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for <textarea> (just like in MDC Web) #118

Closed
jimbojetlag opened this issue Jun 27, 2018 · 6 comments
Closed

Add support for <textarea> (just like in MDC Web) #118

jimbojetlag opened this issue Jun 27, 2018 · 6 comments

Comments

@jimbojetlag
Copy link

Is TextField supposed to wrap textarea instead of the provided Input when the prop textarea is set to true?

Will there be also a wrapper for textarea similar to Input?

@jimbojetlag
Copy link
Author

If so, maybe the docs should be updated with a working multiline editor.

@qpjsir
Copy link

qpjsir commented Jun 28, 2018

厉害了

@moog16
Copy link

moog16 commented Jun 28, 2018

Originally the idea was to add a <TextArea> component similar to <Input>. There were some issues with the core repo that we had with textarea at the time, so we skipped it during launch. We will need to circle back and add in this component.

For the time being I think it is possible to just use a regular <textarea> element. Would it work if I added an example of that in the docs?

@jimbojetlag
Copy link
Author

A working example with regular <textarea> would be useful. I ran into difficulties with this approach, had to copy/paste the source code for <Input> and replace the <input> tag with <textarea> to get it working.

@moog16
Copy link

moog16 commented Jun 29, 2018

Got it. I'll try getting a working example working and then update the docs.

@lynnmercier lynnmercier changed the title Setting textarea to true for TextField does not make it multiline Add support for <textarea> (just like in MDC Web) Jul 18, 2018
@moog16
Copy link

moog16 commented Aug 10, 2018

While chatting on Discord, a user explained that the outlined and textarea props will trigger a double outline. The intention is to only use the textarea prop. Whatever is documented on MDCW should also be documented here.

bmihelac added a commit to bmihelac/material-components-web-react that referenced this issue Sep 21, 2018
bmihelac added a commit to bmihelac/material-components-web-react that referenced this issue Sep 26, 2018
bmihelac added a commit to bmihelac/material-components-web-react that referenced this issue Sep 26, 2018
bmihelac added a commit to bmihelac/material-components-web-react that referenced this issue Oct 3, 2018
bmihelac added a commit to bmihelac/material-components-web-react that referenced this issue Oct 3, 2018
bmihelac added a commit to bmihelac/material-components-web-react that referenced this issue Oct 9, 2018
@moog16 moog16 closed this as completed Oct 19, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants