-
Notifications
You must be signed in to change notification settings - Fork 701
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
'help_me_plx' #657
base: master
Are you sure you want to change the base?
'help_me_plx' #657
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for your hard work on this project! 😊 While your code meets many of the task requirements, there are a few critical issues that need to be addressed before we can approve the Pull Request:
-
Import Statement: The task requires using
import datetime
, but the current code usesfrom datetime import datetime
. Please adjust this to meet the requirement. -
Cost Calculation: The trip cost calculation is missing the fuel cost for the return trip home. Ensure that this is included to accurately reflect the total cost.
-
Missing
config.json
File: The application relies on aconfig.json
file for configuration data, but it is not included. Please add this file to ensure the application functions correctly.
Once these issues are resolved, your code will be in great shape! Keep up the great work, and I look forward to seeing the improvements. 🚀
✨ Please rate this review in the Platform's notification center. I will be grateful for your feedback! ✨
🔄 Fix the issues, commit the changes, and then re-request my review using the Re-request review
button in the Reviewers tab.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great job on your implementation! 🎉 Your code is mostly aligned with the task requirements, and you've made good progress. Here are a few points to consider for improvement:
-
Import Statement: Please correct the import statement in
customer.py
to useimport datetime
instead offrom datetime import datetime
. This will meet the task requirements. -
Fuel Cost Calculation: You've correctly included the return trip in the fuel cost calculation, which is excellent. Make sure that the
config.json
file contains theFUEL_PRICE
key to avoid any runtime errors. -
Missing
config.json
File: Ensure that theconfig.json
file is added to your project. This file is crucial as it contains configuration data such asFUEL_PRICE
,customers
, andshops
.
While there are some issues to address, the decision to approve your pull request is made to help you move forward with your learning. Please review the comments and make the necessary improvements to your code. Keep up the good work and continue learning from these experiences! 🚀
✨ Please rate this review in the Platform's notification center. I will be grateful for your feedback! ✨
fuel_cost = (distance / 100) * self.car.fuel_consumption | ||
return round(fuel_cost * 2 * config["FUEL_PRICE"], 2) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The fuel cost calculation correctly includes the return trip by multiplying by 2. Ensure that the config.json
file contains the FUEL_PRICE
key to avoid runtime errors.
No description provided.