Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

'help_me_plx' #657

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

Hulk-hurry-Hulk-smash
Copy link

No description provided.

Copy link

@mateacademy-ai-mentor mateacademy-ai-mentor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your hard work on this project! 😊 While your code meets many of the task requirements, there are a few critical issues that need to be addressed before we can approve the Pull Request:

  1. Import Statement: The task requires using import datetime, but the current code uses from datetime import datetime. Please adjust this to meet the requirement.

  2. Cost Calculation: The trip cost calculation is missing the fuel cost for the return trip home. Ensure that this is included to accurately reflect the total cost.

  3. Missing config.json File: The application relies on a config.json file for configuration data, but it is not included. Please add this file to ensure the application functions correctly.

Once these issues are resolved, your code will be in great shape! Keep up the great work, and I look forward to seeing the improvements. 🚀

✨ Please rate this review in the Platform's notification center. I will be grateful for your feedback! ✨

🔄 Fix the issues, commit the changes, and then re-request my review using the Re-request review button in the Reviewers tab.

Copy link

@mateacademy-ai-mentor mateacademy-ai-mentor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job on your implementation! 🎉 Your code is mostly aligned with the task requirements, and you've made good progress. Here are a few points to consider for improvement:

  1. Import Statement: Please correct the import statement in customer.py to use import datetime instead of from datetime import datetime. This will meet the task requirements.

  2. Fuel Cost Calculation: You've correctly included the return trip in the fuel cost calculation, which is excellent. Make sure that the config.json file contains the FUEL_PRICE key to avoid any runtime errors.

  3. Missing config.json File: Ensure that the config.json file is added to your project. This file is crucial as it contains configuration data such as FUEL_PRICE, customers, and shops.

While there are some issues to address, the decision to approve your pull request is made to help you move forward with your learning. Please review the comments and make the necessary improvements to your code. Keep up the good work and continue learning from these experiences! 🚀

✨ Please rate this review in the Platform's notification center. I will be grateful for your feedback! ✨

Comment on lines +30 to +31
fuel_cost = (distance / 100) * self.car.fuel_consumption
return round(fuel_cost * 2 * config["FUEL_PRICE"], 2)

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The fuel cost calculation correctly includes the return trip by multiplying by 2. Ensure that the config.json file contains the FUEL_PRICE key to avoid runtime errors.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants