-
Notifications
You must be signed in to change notification settings - Fork 701
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
solution #650
base: master
Are you sure you want to change the base?
solution #650
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for your hard work on this Pull Request! 😊 There are a couple of critical issues that need to be addressed before we can proceed. The typo in the parameter name fuel_pice
should be corrected to fuel_price
to ensure consistency and clarity across your code. Additionally, please ensure that the location
parameter is correctly typed as a list of integers (list[int]
) to align with the task requirements. Once these changes are made, your code will be in great shape! Keep up the great work! 🚀
✨ Please rate this review in the Platform's notification center. I will be grateful for your feedback! ✨
🔄 Fix the issues, commit the changes, and then re-request my review using the Re-request review
button in the Reviewers tab.
app/customer.py
Outdated
def cost_trip( | ||
self, | ||
location: list[int, int], | ||
fuel_pice: float |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is a typo in the parameter name fuel_pice
. It should be fuel_price
to match the task description and maintain consistency.
app/customer.py
Outdated
|
||
def cost_trip( | ||
self, | ||
location: list[int, int], |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ensure that the location
parameter is correctly typed as a list of integers, i.e., list[int]
, to match the task requirements.
app/main.py
Outdated
) | ||
cost = customer_instance.cost_trip( | ||
location=shop_instance.location, | ||
fuel_pice=fuel_price |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is a typo in the parameter name fuel_pice
. It should be fuel_price
to match the task description and maintain consistency.
No description provided.