Solution #561
Open
Solution #561
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pavlejviki
suggested changes
Aug 23, 2023
app/errors.py
Outdated
|
|
||
| class NotVaccinatedError(VaccineError): | ||
| def __str__(self) -> str: | ||
| return "Not vaccinated" |
There was a problem hiding this comment.
your error messages should be more descriptive
app/main.py
Outdated
| for friend in friends: | ||
| try: | ||
| cafe.visit_cafe(friend) | ||
| except (NotVaccinatedError, OutdatedVaccineError): |
There was a problem hiding this comment.
You can catch the parent class VaccineError instead of the two child classes
app/main.py
Outdated
| @@ -1 +1,18 @@ | |||
| # write your code here | |||
| from app.cafe import Cafe | |||
| from app.errors import (NotVaccinatedError, | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.