-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
'Solution' #538
Open
hanovskyiv
wants to merge
3
commits into
mate-academy:master
Choose a base branch
from
hanovskyiv:develop
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
'Solution' #538
Changes from all commits
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,21 @@ | ||
import datetime | ||
from app.errors import ( | ||
NotVaccinatedError, | ||
OutdatedVaccineError, | ||
NotWearingMaskError | ||
) | ||
|
||
|
||
class Cafe: | ||
|
||
def __init__(self, name: str) -> None: | ||
self.name = name | ||
|
||
def visit_cafe(self, visitor: dict) -> str: | ||
if "vaccine" not in visitor: | ||
raise NotVaccinatedError | ||
if datetime.date.today() > visitor["vaccine"]["expiration_date"]: | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. In case you are unsure about the incoming dict structure, it would be preferable to use |
||
raise OutdatedVaccineError | ||
if not visitor["wearing_a_mask"]: | ||
raise NotWearingMaskError | ||
return f"Welcome to {self.name}" |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,17 @@ | ||
class VaccineError(Exception): | ||
pass | ||
|
||
|
||
class NotVaccinatedError(VaccineError): | ||
def __str__(self) -> str: | ||
return "Visitor is not vaccinated" | ||
|
||
|
||
class OutdatedVaccineError(VaccineError): | ||
def __str__(self) -> str: | ||
return "Vaccine is outdated" | ||
|
||
|
||
class NotWearingMaskError(Exception): | ||
def __str__(self) -> str: | ||
return "Visitor is not wearing a mask" |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1 +1,16 @@ | ||
# write your code here | ||
from app.cafe import Cafe | ||
from app.errors import VaccineError, NotWearingMaskError | ||
|
||
|
||
def go_to_cafe(friends: list[dict], cafe: Cafe) -> str: | ||
not_wearing_masks = 0 | ||
for visitor in friends: | ||
try: | ||
cafe.visit_cafe(visitor) | ||
except NotWearingMaskError: | ||
not_wearing_masks += 1 | ||
except VaccineError: | ||
return "All friends should be vaccinated" | ||
if not not_wearing_masks: | ||
return "Friends can go to KFC" | ||
return f"Friends should buy {not_wearing_masks} masks" |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It would be preferable to place at the first position a value that you want to check from the function input and the value you check against in the second position.