Solution #1231
Solution #1231
Conversation
There was a problem hiding this comment.
Thank you for your hard work on this project! 😊 There are a few critical issues that need to be addressed before we can approve the pull request. Specifically, the key name inconsistency in the Cafe class and the logical issue in the go_to_cafe function need to be resolved to ensure the code functions correctly. Additionally, correcting the typos in the error messages will improve clarity and professionalism. Once these changes are made, your solution will be in great shape! Keep up the great work! 🚀
✨ Please rate this review in the Platform's notification center. I will be grateful for your feedback! ✨
🔄 Fix the issues, commit the changes, and then re-request my review using the Re-request review button in the Reviewers tab.
app/cafe.py
Outdated
|
|
||
| def visit_cafe(self, visitor: dict) -> str: | ||
| if "vaccine" not in visitor: | ||
| raise NotVaccinatedError("Visitor is not vaccined.") |
There was a problem hiding this comment.
There is a typo in the error message: 'vaccined' should be 'vaccinated'.
app/cafe.py
Outdated
| raise OutdatedVaccineError("Vaccine expiration date is missing.") | ||
|
|
||
| if expiration_date < datetime.now().date(): | ||
| raise OutdatedVaccineError("Vaccine is expirited.") |
There was a problem hiding this comment.
There is a typo in the error message: 'expirited' should be 'expired'.
app/cafe.py
Outdated
| if expiration_date < datetime.now().date(): | ||
| raise OutdatedVaccineError("Vaccine is expirited.") | ||
|
|
||
| if not visitor.get("wear masks", False): |
There was a problem hiding this comment.
The key 'wear masks' in the visitor dictionary should be consistent with the expected key. Consider using 'wear_mask' or 'wearing_mask' to avoid confusion.
| try: | ||
| cafe.visit_cafe(friend) | ||
| except VaccineError: | ||
| return "All friends should be vaccinated" |
There was a problem hiding this comment.
Returning immediately upon catching a VaccineError means that if any friend is not vaccinated, the function will not check the rest of the friends. Consider accumulating results for all friends before deciding on the return value.
There was a problem hiding this comment.
Your code meets the task requirements and constraints, and it's clear you've put in a lot of effort. 🎉 However, there are a few critical issues that need attention:
-
CafeClass: Ensure thatexpiration_dateis adateobject before comparing it withdatetime.now().date(). Ifexpiration_dateis a string, parse it into adateobject to avoid errors. -
Visitor Dictionary Check: When checking for the 'vaccine' key, ensure its value is not
Noneto prevent potential errors. -
go_to_cafeFunction: The current logic may cause the function to exit prematurely if any friend is not vaccinated. Consider revising the logic to accumulate messages or use a flag, and return after the loop to ensure all friends are checked.
Your implementation of error classes and the overall structure is well done. Keep up the good work, and make sure to address these issues in future projects to enhance your coding skills. Keep learning and improving! 🚀
✨ Please rate this review in the Platform's notification center. I will be grateful for your feedback! ✨
| self.name = name | ||
|
|
||
| def visit_cafe(self, visitor: dict) -> str: | ||
| if "vaccine" not in visitor: |
There was a problem hiding this comment.
Consider checking if the 'vaccine' key exists and its value is not None to avoid potential errors.
|
|
||
| expiration_date = visitor["vaccine"].get("expiration_date") | ||
|
|
||
| if expiration_date < datetime.now().date(): |
There was a problem hiding this comment.
Ensure that expiration_date is a date object before comparing it with datetime.now().date(). If expiration_date is a string, you should parse it into a date object.
| try: | ||
| cafe.visit_cafe(friend) | ||
| except VaccineError: | ||
| return "All friends should be vaccinated" |
There was a problem hiding this comment.
Returning immediately upon catching a VaccineError will stop the loop and prevent checking other friends. Consider accumulating a message or a flag and returning after the loop to ensure all friends are processed.
No description provided.