Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Solution #1771

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Solution #1771

wants to merge 4 commits into from

Conversation

B0hdanR
Copy link

@B0hdanR B0hdanR commented Nov 6, 2024

No description provided.

Copy link

@mateacademy-ai-mentor mateacademy-ai-mentor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.


Great job on your code! 🎉 The functions format_linter_error, format_single_linter_file, and format_linter_report are implemented correctly and meet the task requirements. The code is well-structured and follows a clear logic.

However, there's a minor issue with the import statement on line 1 in app/main.py. The import from dbm import error seems incorrect or unnecessary, as the dbm module does not have an error attribute relevant to your current implementation. Consider reviewing this import and removing or replacing it if it's not needed.

Keep up the good work, and happy coding! 😊

✨ Please rate this review in the Platform's notification center. I will be grateful for your feedback! ✨

app/main.py Outdated Show resolved Hide resolved
Copy link

@vsmutok vsmutok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tests failed!

app/main.py Outdated Show resolved Hide resolved
@B0hdanR
Copy link
Author

B0hdanR commented Nov 7, 2024

it's a bit weird because without json it wanted me to change the single quotes to double quotes, but now everything works.

@B0hdanR B0hdanR requested a review from vsmutok November 7, 2024 18:31
app/main.py Outdated Show resolved Hide resolved
app/main.py Outdated Show resolved Hide resolved
app/main.py Outdated Show resolved Hide resolved
@B0hdanR B0hdanR requested a review from pavlopro November 7, 2024 19:27
Copy link

@pavlopro pavlopro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

GJ!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants