-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Solution #1771
base: master
Are you sure you want to change the base?
Solution #1771
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great job on your code! 🎉 The functions format_linter_error
, format_single_linter_file
, and format_linter_report
are implemented correctly and meet the task requirements. The code is well-structured and follows a clear logic.
However, there's a minor issue with the import statement on line 1 in app/main.py
. The import from dbm import error
seems incorrect or unnecessary, as the dbm
module does not have an error
attribute relevant to your current implementation. Consider reviewing this import and removing or replacing it if it's not needed.
Keep up the good work, and happy coding! 😊
✨ Please rate this review in the Platform's notification center. I will be grateful for your feedback! ✨
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
tests failed!
it's a bit weird because without json it wanted me to change the single quotes to double quotes, but now everything works. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
GJ!
No description provided.