Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

result for task #1318

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
52 changes: 51 additions & 1 deletion app/main.py
Original file line number Diff line number Diff line change
@@ -1 +1,51 @@
# write your code here
class Animal:
def __init__(self,
name: str,
appetite: int,
is_hungry: bool = True
) -> None:
self.name = name
self.appetite = appetite
self.is_hungry = is_hungry

def print_name(self) -> str:
print(f"Hello, I'm {self.name}")

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The method print_name is declared to return a str, but it actually returns None because it only prints the name. Consider changing the return type to None or returning a string instead.


def feed(self) -> int:
if self.is_hungry is True:
print(f"Eating {self.appetite} food points...")
self.is_hungry = False
return self.appetite
return 0


class Cat(Animal):
def __init__(self,
name: str,
is_hungry: bool = True,
appetite: int = 3
) -> None:
super().__init__(name, appetite, is_hungry)

def catch_mouse(self) -> str:
print("The hunt began!")

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The method catch_mouse is declared to return a str, but it actually returns None because it only prints a message. Consider changing the return type to None or returning a string instead.



class Dog(Animal):
def __init__(self, name: str,
is_hungry: bool = True,
appetite: int = 7
) -> None:
super().__init__(name, appetite, is_hungry)

def bring_slippers(self) -> str:
print("The slippers delivered!")

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The method bring_slippers is declared to return a str, but it actually returns None because it only prints a message. Consider changing the return type to None or returning a string instead.



def feed_animals(animals: list) -> int:
points_sum = 0
for animal in animals:
if animal.is_hungry is True:
points_sum += animal.appetite

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The condition if animal.is_hungry is True: is redundant. You can simply use if animal.is_hungry: for a cleaner and more Pythonic approach.

animal.feed()
return points_sum
Comment on lines +47 to +48

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The logic here adds the animal's appetite to points_sum before calling animal.feed(). This means points_sum will include the appetite of animals that are fed in this iteration. If you want points_sum to reflect only the appetite of animals that were hungry before feeding, the current logic is correct. Otherwise, consider adjusting the logic.

Loading