solution #665

Taras0506 · 2023-04-10T09:36:32Z

anstsot

Please check the links, add the report and fix your code according to checklist. Please add all needed fields as shown in the task.

src/index.html

VitaliyBondarenko1982

check demo links.
they does not work

VitaliyBondarenko1982 · 2023-04-18T18:31:49Z

src/index.html

+        <label class="form-field">
+        Surname:
+          <input


Suggested change

<label class="form-field">

Surname:

<input

<label class="form-field">

Surname:

<input

VitaliyBondarenko1982 · 2023-04-18T18:33:15Z

src/index.html

+        <label class="form-field">
+        How old are You?
+          <input


Suggested change

<label class="form-field">

How old are You?

<input

<label class="form-field">

How old are You?

<input

check and fix other places of wrong indentation

still not fixed

VitaliyBondarenko1982 · 2023-04-18T18:35:20Z

src/index.html

+          <label>
+            <input
+              type="radio"
+              name="sex"
+          value="m"
+          >


Suggested change

<label>

<input

type="radio"

name="sex"

value="m"

>

<label>

<input

type="radio"

name="sex"

value="m"

>

VitaliyBondarenko1982 · 2023-04-18T18:36:06Z

src/style.css

+.field::placeholder {
+  color: green;
+}


Suggested change

.field::placeholder {

color: green;

}

redundant

Taras0506 · 2023-04-20T17:45:14Z

check demo links. they does not work

Hi, please write how its correct?

Taras0506 · 2023-04-20T19:11:03Z

check demo links. they does not work

Hi, please write how its correct.
I don't know why ,but my line with that links is empty.
Could you copy it for me here please if its possible of course.

etojeDenys

if you have some problems with deploy, feel free to ask about it in the slack chat!

etojeDenys · 2023-04-22T09:12:51Z

src/index.html

+            <option selected>BMW</option>
+            <option selected>Audi</option>
+            <option>Lada</option>
+            <option></option>


There is an empty <option> element in the select field for favorite brand of cars. You can remove it or add a value to it, such as 'Other'. 🚗

Anastasiia-Svintsova · 2023-04-22T11:17:59Z

src/index.html

+          <input
+            name="feedback"
+            placeholder="mm/dd/yyyy"
+            rows="1"
+            cols="20"
+          >


It should be an input with a date type. And why do you need rows and cols attributes here?

Its doesnt logic, you right!
Add type="date"

Anastasiia-Svintsova · 2023-04-22T11:19:56Z

src/index.html

    <script type="text/javascript" src="./main.js"></script>
+    <form
+      action="http://localhost:3000/api"


Fix the action here according to the requirements

I can`t open this link. I must insert instead this link in line action ?

Anastasiia-Svintsova · 2023-04-22T11:20:11Z

src/index.html

+        <label class="form-field">
+        Surname:


Check the code style

Suggested change

<label class="form-field">

Surname:

<label class="form-field">

Surname:

still not fixed

Anastasiia-Svintsova · 2023-04-22T11:21:04Z

src/index.html

+            rows="1"
+            cols="20"


Remove these rows and sols everywhere, please

Anastasiia-Svintsova · 2023-04-22T11:21:22Z

src/index.html

+        </label>
+        <label class="form-field">


Don't forget to add empty lines between multiline sibling blocks of HTML

Suggested change

</label>

<label class="form-field">

</label>

<label class="form-field">

readme.md

OleziO

Fix the demo link.

Taras0506 · 2023-04-23T15:01:54Z

Explain please how to fix it? I understand that its simply task , but it doesnt work... I check every line before, what`s the reasons

VitaliyBondarenko1982

I fixed demo link in PR description (was missed / in url)
Test report link still not works.
Try to run npm test locally and deploy again.
If test report link stiil will be wrong, make screenshot with tests and show it in PR

VitaliyBondarenko1982 · 2023-04-23T15:29:43Z

src/style.css

+.field:invalid {
+  border: 1px solid red;
+}
+
+.field:focus {
+  background-color: azure;
+}
+
+.field:checked ~ .form__label {
+  color: grey;
+}


Suggested change

.field:invalid {

border: 1px solid red;

}

.field:focus {

background-color: azure;

}

.field:checked ~ .form__label {

color: grey;

}

looks like redundant styles for this task

Taras0506 · 2023-04-23T18:21:27Z

how to rigth correct this error ?

Taras0506 · 2023-04-23T19:07:10Z

Add second screenshot

etojeDenys

if you have any problems with the deploy, ask it in the chat, we will be able to help you as soon as possible

etojeDenys · 2023-04-24T07:29:30Z

src/index.html

+        <label class="form-field">
+        How old are You?
+          <input


still not fixed

etojeDenys

report link still does not work

etojeDenys · 2023-04-26T06:18:33Z

src/index.html

+        <label class="form-field">
+          Surname:
+          <input
+            name="feedback"


The 'name' attribute should be unique for each input field. Please change the 'name' attribute for the Surname input field to something like 'surname'.

fix it everywhere

Taras0506 · 2023-04-26T18:44:55Z

report link still does not work

Hi! What does look like this link ? Why its doesnt work ?

etojeDenys · 2023-04-27T16:56:59Z

src/index.html

+        <label class="form-field">
+        Name:
+          <input
+            surname="feedback"


The attribute for the Name input should be 'name' instead of 'surname'

etojeDenys · 2023-04-27T16:56:59Z

src/index.html

+            type="range"
+            id="rate"
+            min="0"
+          >


The 'name' attribute is missing for the How do you rate your work range input

etojeDenys · 2023-04-27T16:56:59Z

src/index.html

+        </label>
+        <div class="form_field">
+        What are your favorite brand of cars?
+          <select name="text">


The 'name' attribute for the favorite brand of cars select input should be 'brand' or a more descriptive name instead of 'text'

etojeDenys · 2023-04-27T16:59:16Z

src/index.html

+        <label class="form-field">
+        Surname:


still not fixed

etojeDenys · 2023-04-27T17:04:08Z

report link still does not work

Hi! What does look like this link ? Why its doesnt work ?

if you have any problems with the deploy, ask it in the chat, we will be able to help you as soon as possible

etojeDenys

reports link still does not work, and all prev comments are not resolved

VitaliyBondarenko1982

About wrong test report link.
Ran your project locally.
A lot of tests failed.

First of all run tests locally (npm test), compare reference and test and fix them.
For success deploy tests link should be backstop folder in project.
For fix tests check class names form-field (in some places it is form_field)
add class for fieldset and such styles

   margin-bottom: 20px;
   padding-bottome: 0

and for form-field

  .form-field {
    display: block;
    margin-bottom: 10px;
  }

if test demo link will be wrong at least fix tests locally and add screenshot as above but with correct tests.
and if you have any questions about how to fix tests - feel free to ask in fe_chat

VitaliyBondarenko1982 · 2023-05-01T11:13:01Z

src/index.html

+        <label class="form-field">
+        What time do you go to bed?
+          <input


Suggested change

<label class="form-field">

What time do you go to bed?

<input

<label class="form-field">

What time do you go to bed?

<input

still not fixed in all similar places

VitaliyBondarenko1982 · 2023-05-01T11:13:48Z

src/index.html

+            <option>Other</option>
+          </select>
+        </div>
+        <label for="start">


Suggested change

<label for="start">

<label for="rate">

for and id in input should be the same

VitaliyBondarenko1982 · 2023-05-01T11:14:12Z

src/index.html

+            value="--:--:--"
+          >
+        </label>
+        <div class="form_field">


Suggested change

<div class="form_field">

<div class="form-field">

solution

2a3f3c7

anstsot suggested changes Apr 10, 2023

View reviewed changes

src/index.html Outdated Show resolved Hide resolved

solution

09af41e

Taras0506 requested a review from anstsot April 18, 2023 18:30

VitaliyBondarenko1982 suggested changes Apr 18, 2023

View reviewed changes

solution

b1b443a

Taras0506 requested a review from VitaliyBondarenko1982 April 22, 2023 08:41

etojeDenys suggested changes Apr 22, 2023

View reviewed changes

solution

0a6d9d3

Taras0506 requested a review from etojeDenys April 22, 2023 09:59

Anastasiia-Svintsova suggested changes Apr 22, 2023

View reviewed changes

develop

ad00a0d

Taras0506 requested a review from Anastasiia-Svintsova April 22, 2023 12:59

OleziO suggested changes Apr 23, 2023

View reviewed changes

Taras0506 requested a review from OleziO April 23, 2023 14:57

VitaliyBondarenko1982 suggested changes Apr 23, 2023

View reviewed changes

solution

3dcef15

Taras0506 requested a review from VitaliyBondarenko1982 April 23, 2023 19:09

etojeDenys suggested changes Apr 24, 2023

View reviewed changes

src/index.html

Comment on lines +38 to +40

<label class="form-field">

How old are You?

<input

Copy link

etojeDenys Apr 24, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

still not fixed

Taras0506 mentioned this pull request Apr 24, 2023

still not fixed #774

Open

Taras0506 added 2 commits April 25, 2023 20:04

solution

e9acd01

solution

42e070a

Taras0506 requested a review from etojeDenys April 25, 2023 18:19

etojeDenys suggested changes Apr 26, 2023

View reviewed changes

solution

b07d2c2

Taras0506 requested a review from etojeDenys April 27, 2023 16:46

etojeDenys suggested changes Apr 27, 2023

View reviewed changes

Taras0506 requested a review from etojeDenys April 28, 2023 18:06

etojeDenys suggested changes Apr 29, 2023

View reviewed changes

Taras0506 requested a review from etojeDenys May 1, 2023 10:32

VitaliyBondarenko1982 suggested changes May 1, 2023

View reviewed changes

Taras0506 closed this by deleting the head repository Jun 25, 2023

solution #665

solution #665

Conversation

Taras0506 commented Apr 10, 2023 • edited Loading

anstsot left a comment

Choose a reason for hiding this comment

VitaliyBondarenko1982 left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Taras0506 commented Apr 20, 2023

Taras0506 commented Apr 20, 2023 • edited Loading

etojeDenys left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

OleziO left a comment

Choose a reason for hiding this comment

Taras0506 commented Apr 23, 2023

VitaliyBondarenko1982 left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Taras0506 commented Apr 23, 2023

Taras0506 commented Apr 23, 2023

etojeDenys left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

etojeDenys left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Taras0506 commented Apr 26, 2023

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

etojeDenys commented Apr 27, 2023

etojeDenys left a comment

Choose a reason for hiding this comment

VitaliyBondarenko1982 left a comment • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Taras0506 commented Apr 10, 2023 •

edited

Loading

Taras0506 commented Apr 20, 2023 •

edited

Loading

VitaliyBondarenko1982 left a comment •

edited

Loading