Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add task solution #998

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

add task solution #998

wants to merge 5 commits into from

Conversation

LASHCH-Y
Copy link

Copy link

@volodymyr-soltys97 volodymyr-soltys97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job 👍
Let's improve your page

  1. Add border radius for these cards, check it on the design
image
  1. You need to change autofill styles for the form fields
    https://css-tricks.com/snippets/css/change-autocomplete-styles-webkit-browsers/
image
  1. Add cursor pointer for all clickable elements on the page
image

Copy link

@vadiimvooo vadiimvooo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job, a few things to fix:

  1. Remove page refresh on form sunmittion
    image
  2. Add transition on hover effect for all interactive elements on page (example on screenshot below)
    image

Copy link

@volodymyr-soltys97 volodymyr-soltys97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Almost done!
To improve:

  1. This comment still not fixed from the previous review
image

Copy link

@etojeDenys etojeDenys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants