-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Nav #747
base: master
Are you sure you want to change the base?
Nav #747
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Continue the conversation in the chat
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like some sections not finished
Also:
- do not show hamburger icon when visible navigation
- add hover effect for nav links. check other interactive elements.
- after click on hamburger icon nothing happen. menu still closed
- click on slider buttons leads to 404 page
Pay attention on checklist
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good job! There are things that should be fixed:
- fix 404 error by
about us
link click (same for nav links in footer) - make sure that all interactive elements have a cursor pointer on hover
- would be great if something happens by click on nav links (same for nav links in footer)
- fix 404 error by carousel button click
- fix these blocks according design for desktop mode
- fix placeholder
- remove default autocomplete background color, it breaks design
- make all form field required
- always open links in new tab
- add social links to appropriate icons (instagram, facebook, twitter)
- add smooth scroll to page by navigate, now user teleported after link click
- fix menu. It doesn't work by click on burger menu icon
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great job overall! Just couple tiny things needs to be fixed before approval)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good job! There are things that should be fixed:
- center this block (need stretch)
- fix footer according design
design desktop mode
your version
- add right indents for social according design
- fix blocks width according design (264px)
your version
I'll help you with width and fix all in the card according design (indents between text and icons, font-size etc)
- add right paddings for these blocks
- add background and check indents according design
your version
design version
- fix menu, it doesn't work
- also check whole your page for tablet and mobile mode and fix according design (for example remove this line)
- there is no need open new tab phone number link
If you have any questions, please ask them in fe_chat and tag mentors. It will be faster, because your answers in GitHub will be visible to mentor only after you re-request review
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good job! need some improvements
- check yourself with indents from figma for these blocks. Check each block on the page like this, and not only in the place where mentors left comments
- according design background color should be white
- cross icon should be the same place with burger menu icon
- add hover effect for menu links
- check yourself and fix all mismatches with design
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good improvements 👍
Let's add more - pay attention to the checklist
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You've got this, keep pushing forward!
DEMO LINK