Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

initial commit for Dia landing page #738

Open
wants to merge 15 commits into
base: master
Choose a base branch
from

Conversation

tania-kuzmenko
Copy link

Copy link

@anastasiia-tilikina anastasiia-tilikina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please look closer again to design and check again your implementation.These are fixes that I have already noticed. But I'd suggested you to double check the entire landing.

  1. This link in header is broken. Usually logo link leads to home. So lets jus add href='#'

image

  1. Check gaps between nav links on desktop
    Your landing:
    image

Figma:
image

  1. This should be link as well

image

  1. Let's make this button a link that leads to Who we are section

image

  1. Add some hover effects on pictures here

image

  1. These two sections have different background color
    Your landing:
    image
    Figma:
    image

  2. Add hover effects on cards and buttons (check in Figma)

  3. Reset default styles for learn more link texts

image

  1. paragraph here should have different font-weight
    Your landing:
    image

Figma:
image

  1. Add some hover effects on these cards

image

  1. This section looks different than in Figma. There is no task to make it pixel perfect but it should be implemented as close to design as possible
  • height is different,
  • the next section overlaps background elements

Your landing:
image

Figma:
image

  1. This style should be on focus not hover

image

  1. Reset default focus styles of inputs

image

  1. First input shows style of input's text not placeholder. But second and 3rd inputs show how placeholders should look.
  2. The placeholder of first input should be Email

image

  1. User shouldn't be able to resize textarea

image

  1. email input should have type=email

  2. shouldn't be submitted and shouldn't reload page. It only has to reset inputs

  3. Social media links should have hover styles (check Figma)

  4. add some hover style to address link

image

  1. This small underscore on slider buttons is default link style. it should be reseted.

image

  1. If you're not going to implement slider, I'd suggest you to remove these buttons, since it looks a bit confusing for user

  2. who we are section also has different background color
    Your landing:
    image

Figma:
image

  1. These texts in testimonial card should always be on the same level despite on screen width and card width and amount of text.

Your landing:
image

Figma:
image

  1. I believe this title should always be divided by two rows
    Your landing:
    image

Figma:
image

  1. This button on mobile devices should open hamburger menu

image

  1. Look closer on grid layout of this section (width 640px) It looks a bit different comparing with Figma

Your landing:
image

Figma:
image

  1. I believe title here should fit in on one row (width 640px)
    Your landing:
    image

Figma:
image

  1. The same here:
    image

  2. Cards should have paddings (check design)
    image

  3. Text shouldn't be aligned on center here

image

Copy link

@anastasiia-tilikina anastasiia-tilikina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Much better)
but we still have some issues to fix)

  1. This link is still broken(
    image

  2. These cards have box-shadow (check Figma)
    image

  3. this paragraph is still has different font-weight
    image

  4. this link is broken in the footer
    image

  5. placeholders should have different styles (check Figma)
    image

  6. this text has different color (check Figma)
    image

  7. your form still reloads page on submit while it shouldn't

  8. this link in mob menu is broken
    image

  9. as well as here
    image

Copy link

@maxim2310 maxim2310 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job overall! Just couple things needs to be fixed before approval)

  1. try to remove outofill background
    input:-webkit-autofill,
    input:-webkit-autofill:hover,
    input:-webkit-autofill:focus,
    input:-webkit-autofill:active{
    -webkit-box-shadow: 0 0 0 30px white inset !important;
    }
    image
  2. on my laptop screen it looks like. Try to contain all element inside that they do not overlap each other
    image

Copy link

@maxim2310 maxim2310 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well done!!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants