-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
initial commit for Dia landing page #738
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please look closer again to design and check again your implementation.These are fixes that I have already noticed. But I'd suggested you to double check the entire landing.
- This link in header is broken. Usually logo link leads to home. So lets jus add
href='#'
- This should be link as well
- Let's make this button a link that leads to
Who we are
section
- Add some hover effects on pictures here
-
These two sections have different background color
Your landing:
Figma:
-
Add hover effects on cards and buttons (check in Figma)
-
Reset default styles for
learn more
link texts
- Add some hover effects on these cards
- This section looks different than in Figma. There is no task to make it pixel perfect but it should be implemented as close to design as possible
- height is different,
- the next section overlaps background elements
- This style should be on
focus
nothover
- Reset default focus styles of inputs
- First input shows style of input's text not placeholder. But second and 3rd inputs show how placeholders should look.
- The placeholder of first input should be
Email
- User shouldn't be able to resize
textarea
-
email input should have
type=email
-
shouldn't be submitted and shouldn't reload page. It only has to reset inputs
-
Social media links should have hover styles (check Figma)
-
add some hover style to address link
- This small underscore on slider buttons is default link style. it should be reseted.
-
If you're not going to implement slider, I'd suggest you to remove these buttons, since it looks a bit confusing for user
-
who we are
section also has different background color
Your landing:
- These texts in testimonial card should always be on the same level despite on screen width and card width and amount of text.
- This button on mobile devices should open hamburger menu
- Look closer on grid layout of this section (width 640px) It looks a bit different comparing with Figma
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Much better)
but we still have some issues to fix)
-
your form still reloads page on submit while it shouldn't
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great job overall! Just couple things needs to be fixed before approval)
- try to remove outofill background
input:-webkit-autofill,
input:-webkit-autofill:hover,
input:-webkit-autofill:focus,
input:-webkit-autofill:active{
-webkit-box-shadow: 0 0 0 30px white inset !important;
}
- on my laptop screen it looks like. Try to contain all element inside that they do not overlap each other
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Well done!!!
https://tania-kuzmenko.github.io/layout_dia/