-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
implementation #736
base: master
Are you sure you want to change the base?
implementation #736
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please attached demo link to PR
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice start! Check the design more thoroughly
-
Check the text position on the desktop. It doesn't match the design
-
Use SVG for the logo for better image quality
-
This hover effect looks strange in my opinion. Could you use a better approach to avoid overlapping?
-
Cards don't match the design. And add a hover effect as well
-
This button should be rounded, has a hover effect, and lead to some section.
-
All external links should be opened in a new tab
-
The form doesn't work correctly. It should be cleared after submitting
-
The logo in the footer should lead to the top of the page
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The demo link isn't working now
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pls watch the video review :)
Attention.to.Design.Issues.mp4
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good work!
There are several things to improve.
-
It's better to add cursor: pointer on hover any interactive elements. For example, buttons on your slider:
It's the best practice for user experience. -
I see you added a blue color on insta hover, but it should be the same behavior for any other social icons. It should be a general solution.
-
It may be something went wrong, but the mobile menu doesn't open on the menu click.
Could you check it, please?
Other things look good for me. Good job!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Did you forget to redeploy the project?) Previous comments aren’t fixed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
https://nadieinoleh.github.io/layout_dia/