Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dia #733

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

dia #733

wants to merge 6 commits into from

Conversation

antonshtef
Copy link

Copy link

@IvanFesenko IvanFesenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Design missmatch
2023-08-01_13h40_26

2023-08-01_13h41_19

Fix scrolling - it shoul lead to the section starts not section header
https://github.com/mate-academy/layout_dia/assets/61904995/f6f34a3c-499b-49cd-9c8e-6e97a28ac28c

Copy link

@polosanya polosanya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!
Here are a few more moments that would be great to fix:

  1. It would be great to add increasing hover effects to all images
    image
  2. Something is wrong with this section
    image
  3. Make sure that you add a transition for the default state of the element to make a hover effect smooth
    image
  4. Font doesn't match the design. Pay attention to the "a" letter
    image
  5. After autocomplete the form, change the default styles. Read more about changing autocomplete styles
    image
  6. Fonts don't match the design here too
    image
    image

Copy link

@sTorba24 sTorba24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work!

placeholder styles mismatch the design
now
image

mock
image

these sections should have the same left margin
image

Copy link

@etojeDenys etojeDenys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

just remove this border
image

Copy link

@VitaliyBondarenko1982 VitaliyBondarenko1982 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job.
Almost done

Copy link

@etojeDenys etojeDenys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants