-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
dia #733
base: master
Are you sure you want to change the base?
dia #733
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fix scrolling - it shoul lead to the section starts not section header
https://github.com/mate-academy/layout_dia/assets/61904995/f6f34a3c-499b-49cd-9c8e-6e97a28ac28c
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice!
Here are a few more moments that would be great to fix:
- It would be great to add increasing hover effects to all images
- Something is wrong with this section
- Make sure that you add a transition for the default state of the element to make a hover effect smooth
- Font doesn't match the design. Pay attention to the "a" letter
- After autocomplete the form, change the default styles. Read more about changing autocomplete styles
- Fonts don't match the design here too
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good job.
Almost done
- please fix this comment
after autcomplete styles for inputs doesn't match the design
- also pay attention on this point from checklist
for message field make textarea instead input.
and suggest to make custom scrollbar for textarea for avoid default browser scrollbar which mismatch wiht design.
https://www.w3schools.com/howto/howto_css_custom_scrollbar.asp
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
DEMO LINK.