Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Develop #4846

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Develop #4846

wants to merge 3 commits into from

Conversation

KwagFN
Copy link

@KwagFN KwagFN commented Nov 12, 2024

  • DEMO LINK
  • TEST REPORT LINK
  • All components follow BEM and use SCSS
  • Repeated sizes and special colors are put to variables
  • Grid is used for the columns
  • Cards are shown in 1, 2, 3, or 4 columns based on screen resolution
  • All changes on :hover are smooth
  • Code follows all the Code Style Rules ❗️

Copy link

@mateacademy-ai-mentor mateacademy-ai-mentor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.


Thank you for your hard work on this project! 😊 There are a few critical issues that need to be addressed before we can approve the pull request:

  1. SCSS Variables: Ensure that all SCSS variables like $main-color, $primary-color-text, and $secondary-color-text are defined or imported correctly to avoid any compilation errors. This is crucial for the styles to compile and function as expected.

  2. Media Query: Correct the typo in the media query by adding a unit to the min-width value. Change min-width: 488 to min-width: 488px to ensure it functions correctly.

  3. Product Card Content: The product cards currently display the same content repeatedly. If this is not intentional, consider using a template engine or JavaScript to dynamically generate unique content for each card.

Once these issues are resolved, your code will be in great shape! Keep up the great work, and feel free to reach out if you need any help. 🚀

✨ Please rate this review in the Platform's notification center. I will be grateful for your feedback! ✨

🔄 Fix the issues, commit the changes, and then re-request my review using the Re-request review button in the Reviewers tab.

Comment on lines +154 to +467
</div>

<a
href="#"
class="card__button-buy"
data-qa="card-hover"
>
Buy
</a>
</div>

<div
class="card"
data-qa="card"
>
<div class="card__product">
<img
src="./images/imac.jpeg"
alt="Imac Image"
class="card__product-image"
/>
</div>

<div class="card__details">
<h1 class="card__details-name">
APPLE A1419 iMac 27" Retina 5K Monoblock (MNED2UA/A)
</h1>

<p class="card__details-code">Product code: 195434</p>

<div class="card__reviews">
<div class="card__reviews-stars card__reviews-stars--4">
<div class="star"></div>
<div class="star"></div>
<div class="star"></div>
<div class="star"></div>
<div class="star"></div>
</div>
<p class="card__reviews-count">Reviews: 5</p>
</div>

<p class="card__details-price">
Price:
<span>$2,199</span>
</p>
</div>

<a
href="#"
class="card__button-buy"
data-qa="card-hover"
>
Buy
</a>
</div>

<div
class="card"
data-qa="card"
>
<div class="card__product">
<img
src="./images/imac.jpeg"
alt="Imac Image"
class="card__product-image"
/>
</div>

<div class="card__details">
<h1 class="card__details-name">
APPLE A1419 iMac 27" Retina 5K Monoblock (MNED2UA/A)
</h1>

<p class="card__details-code">Product code: 195434</p>

<div class="card__reviews">
<div class="card__reviews-stars card__reviews-stars--4">
<div class="star"></div>
<div class="star"></div>
<div class="star"></div>
<div class="star"></div>
<div class="star"></div>
</div>
<p class="card__reviews-count">Reviews: 5</p>
</div>

<p class="card__details-price">
Price:
<span>$2,199</span>
</p>
</div>

<a
href="#"
class="card__button-buy"
data-qa="card-hover"
>
Buy
</a>
</div>

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The product cards are repeated with the same content. If this is not intentional, consider using a template engine or JavaScript to dynamically generate unique content for each card.

&-name {
width: 166px;
font-size: 12px;
color: $primary-color-text;

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ensure that the SCSS variable $primary-color-text is defined or imported from another file to avoid compilation errors.

&-code {
margin: 4px 0 0;
font-size: 10px;
color: $secondary-color-text;

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ensure that the SCSS variable $secondary-color-text is defined or imported from another file to avoid compilation errors.

&-price {
margin: 24px 0 0;
font-size: 12px;
color: $secondary-color-text;

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ensure that the SCSS variable $secondary-color-text is defined or imported from another file to avoid compilation errors.

span {
font-weight: 700;
font-size: 16px;
color: $primary-color-text;

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ensure that the SCSS variable $primary-color-text is defined or imported from another file to avoid compilation errors.

&-link {
text-decoration: none;
padding: 22.5px 0;
color: $primary-color-text;

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ensure that the SCSS variable $primary-color-text is defined or imported from another file to avoid compilation errors.

transition: color 0.5s;

&:hover {
color: $main-color;

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ensure that the SCSS variable $main-color is defined or imported from another file to avoid compilation errors.

}

[data-qa='nav-hover']:hover {
color: $main-color;

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ensure that the SCSS variable $main-color is defined or imported from another file to avoid compilation errors.


a.is-active {
position: relative;
color: $main-color;

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ensure that the SCSS variable $main-color is defined or imported from another file to avoid compilation errors.

height: 4px;
border-radius: 8px;
bottom: -1px;
background-color: $main-color;

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ensure that the SCSS variable $main-color is defined or imported from another file to avoid compilation errors.

Copy link

@mateacademy-ai-mentor mateacademy-ai-mentor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job on addressing the issues from the previous review! 🎉 Your code now meets the task requirements and constraints. The SCSS variables are correctly defined in variables.scss, ensuring consistency across stylesheets. The media queries have been fixed with appropriate units, which is crucial for responsive design. However, the product cards in the HTML file still display identical content. If this is not intentional, consider using a dynamic approach to generate unique content for each card. This will enhance maintainability and adhere to the DRY principle. Keep up the good work and continue improving your code! 🚀

✨ Please rate this review in the Platform's notification center. I will be grateful for your feedback! ✨

Comment on lines +154 to +467
</div>

<a
href="#"
class="card__button-buy"
data-qa="card-hover"
>
Buy
</a>
</div>

<div
class="card"
data-qa="card"
>
<div class="card__product">
<img
src="./images/imac.jpeg"
alt="Imac Image"
class="card__product-image"
/>
</div>

<div class="card__details">
<h1 class="card__details-name">
APPLE A1419 iMac 27" Retina 5K Monoblock (MNED2UA/A)
</h1>

<p class="card__details-code">Product code: 195434</p>

<div class="card__reviews">
<div class="card__reviews-stars card__reviews-stars--4">
<div class="star"></div>
<div class="star"></div>
<div class="star"></div>
<div class="star"></div>
<div class="star"></div>
</div>
<p class="card__reviews-count">Reviews: 5</p>
</div>

<p class="card__details-price">
Price:
<span>$2,199</span>
</p>
</div>

<a
href="#"
class="card__button-buy"
data-qa="card-hover"
>
Buy
</a>
</div>

<div
class="card"
data-qa="card"
>
<div class="card__product">
<img
src="./images/imac.jpeg"
alt="Imac Image"
class="card__product-image"
/>
</div>

<div class="card__details">
<h1 class="card__details-name">
APPLE A1419 iMac 27" Retina 5K Monoblock (MNED2UA/A)
</h1>

<p class="card__details-code">Product code: 195434</p>

<div class="card__reviews">
<div class="card__reviews-stars card__reviews-stars--4">
<div class="star"></div>
<div class="star"></div>
<div class="star"></div>
<div class="star"></div>
<div class="star"></div>
</div>
<p class="card__reviews-count">Reviews: 5</p>
</div>

<p class="card__details-price">
Price:
<span>$2,199</span>
</p>
</div>

<a
href="#"
class="card__button-buy"
data-qa="card-hover"
>
Buy
</a>
</div>

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The product cards are repeated with the same content. If this is not intentional, consider using a template engine or JavaScript to dynamically generate unique content for each card. This will help in maintaining the DRY (Don't Repeat Yourself) principle and make the code easier to manage.

&-name {
width: 166px;
font-size: 12px;
color: $primary-color-text;

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The variable $primary-color-text is used here but not defined in this file. Ensure it is defined or imported from another SCSS file to avoid compilation errors.

&-code {
margin: 4px 0 0;
font-size: 10px;
color: $secondary-color-text;

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The variable $secondary-color-text is used here but not defined in this file. Ensure it is defined or imported from another SCSS file to avoid compilation errors.

&-price {
margin: 24px 0 0;
font-size: 12px;
color: $secondary-color-text;

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The variable $secondary-color-text is used here but not defined in this file. Ensure it is defined or imported from another SCSS file to avoid compilation errors.

span {
font-weight: 700;
font-size: 16px;
color: $primary-color-text;

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The variable $primary-color-text is used here but not defined in this file. Ensure it is defined or imported from another SCSS file to avoid compilation errors.

&-link {
text-decoration: none;
padding: 22.5px 0;
color: $primary-color-text;

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The variable $primary-color-text is used here but not defined in this file. Ensure it is defined or imported from another SCSS file to avoid compilation errors.

transition: color 0.5s;

&:hover {
color: $main-color;

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The variable $main-color is used here but not defined in this file. Ensure it is defined or imported from another SCSS file to avoid compilation errors.

}

[data-qa='nav-hover']:hover {
color: $main-color;

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The variable $main-color is used here but not defined in this file. Ensure it is defined or imported from another SCSS file to avoid compilation errors.


a.is-active {
position: relative;
color: $main-color;

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The variable $main-color is used here but not defined in this file. Ensure it is defined or imported from another SCSS file to avoid compilation errors.

height: 4px;
border-radius: 8px;
bottom: -1px;
background-color: $main-color;

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The variable $main-color is used here but not defined in this file. Ensure it is defined or imported from another SCSS file to avoid compilation errors.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants