Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add task solution #3933

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

add task solution #3933

wants to merge 1 commit into from

Conversation

Olifan
Copy link

@Olifan Olifan commented Nov 8, 2024

  • DEMO LINK

  • TEST REPORT LINK

  • Changing 'month-lengh' and 'start-day' modifier in the code element
    reflects in changing calendar layout

  • Each day has no modifiers, only class (eg. calendar__day)

  • All Typical Mistakes from BEM lesson theory are checked.

  • Code follows all the Code Style Rules ❗️

Copy link

@mateacademy-ai-mentor mateacademy-ai-mentor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job on implementing the calendar! 🎉 Your code meets the task requirements, and you've done well with the SCSS structure, BEM methodology, and hover effects. The only minor issue is the naming of the main SCSS file, which should be main.scss instead of index.scss. This doesn't impact functionality, so you're good to go! Keep up the excellent work and consider this small change for future projects. 😊

✨ Please rate this review in the Platform's notification center. I will be grateful for your feedback! ✨

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants