Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

calendar tank-igorevich #3922

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

tank-igorevich
Copy link

Copy link

@mateacademy-ai-mentor mateacademy-ai-mentor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.


It looks like you've done a great job with the SCSS and HTML structure! 🎉 However, there's a critical issue with linking the SCSS file directly in your HTML. Browsers can't interpret SCSS files, so you'll need to compile your SCSS into a CSS file and link to that CSS file instead. Once you make this change, your project will be all set! Keep up the great work! 😊

✨ Please rate this review in the Platform's notification center. I will be grateful for your feedback! ✨

🔄 Fix the issues, commit the changes, and then re-request my review using the Re-request review button in the Reviewers tab.

@@ -9,10 +9,42 @@
<title>Calendar</title>
<link
rel="stylesheet"
href="styles/index.scss"
href="styles/main.scss"

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The href attribute is linking to a SCSS file (styles/main.scss). Browsers cannot directly interpret SCSS files. You need to compile the SCSS into a CSS file and link to that CSS file instead.

Copy link

@mateacademy-ai-mentor mateacademy-ai-mentor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review Summary

Great job on implementing the calendar component! 🎉 Your code effectively meets the task requirements, utilizing SCSS and BEM methodology, and implementing dynamic day styling with CSS. The use of variables, mixins, and loops in your SCSS file is commendable. However, there are a couple of critical issues to address:

  1. Stylesheet Linking: The HTML file is linking directly to an SCSS file, which browsers cannot interpret. Ensure you compile your SCSS to CSS and link the CSS file instead.

  2. Gap Property: Consider using the $gap-size variable for the gap property in the .calendar class to enhance maintainability and consistency.

These improvements are crucial for the functionality and maintainability of your code. Addressing them will help you avoid similar issues in the future. Keep up the great work and continue learning from these experiences! 🚀

✨ Please rate this review in the Platform's notification center. I will be grateful for your feedback! ✨

@@ -9,10 +9,42 @@
<title>Calendar</title>
<link
rel="stylesheet"
href="styles/index.scss"
href="styles/main.scss"

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The href attribute is pointing to a SCSS file (styles/main.scss). Browsers cannot directly interpret SCSS files. You need to compile the SCSS file to CSS and link the resulting CSS file instead.


.calendar {
flex-flow: wrap;
gap: 1px;

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consider using the $gap-size variable instead of hardcoding the value 1px for the gap property. This will make your code more maintainable and consistent with the rest of your SCSS file.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants