Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ssqs #614

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

ssqs #614

wants to merge 1 commit into from

Conversation

NarianMambetov
Copy link

No description provided.

Copy link

@mateacademy-ai-mentor mateacademy-ai-mentor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job on implementing the getHumanAge function and its tests! 🎉 The code meets the task requirements and constraints, and the tests are well-structured. However, please double-check the test case descriptions and expected results for ages 14 and 23 to ensure they align with the logic of your function. Keep up the great work! 🚀

✨ Please rate this review in the Platform's notification center. I will be grateful for your feedback! ✨

Comment on lines +16 to +18
test('should return [0, 0] for age 14 for both cat and dog', () => {
expect(getHumanAge(14, 14))
.toEqual([0, 0]);

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The test case description and expected result for age 14 returning [0, 0] might not be correct depending on the logic of getHumanAge. Verify if age 14 should indeed map to [0, 0] in human years.

Comment on lines +26 to +28
test('should return [1, 1] for age 23 for both cat and dog', () => {
expect(getHumanAge(23, 23))
.toEqual([1, 1]);

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The test case description and expected result for age 23 returning [1, 1] might not be correct depending on the logic of getHumanAge. Verify if age 23 should indeed map to [1, 1] in human years.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants