Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Solution #593

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

ihorkorshylivskyi
Copy link

No description provided.

Copy link

@mateacademy-ai-mentor mateacademy-ai-mentor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job on implementing the getHumanAge function! 🎉 Your code meets the task requirements and constraints, and the test cases are well-structured to cover various scenarios. However, there's a small discrepancy in one of the test cases: the expected result for getHumanAge(28, 28) should be [3, 3] according to the conversion rules. Please consider updating this test case for accuracy. Keep up the excellent work! 🚀

✨ Please rate this review in the Platform's notification center. I will be grateful for your feedback! ✨

Comment on lines +41 to +44
test('should return different values for the same parameters', () => {
const result = getHumanAge(28, 28);

expect(result).toEqual([3, 2]);

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The expected result [3, 2] for getHumanAge(28, 28) does not match the conversion rules provided in the task description. According to the rules, both cat and dog ages should convert to [3, 3]. Please verify and correct the expected result.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants