Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused hybrid.css, rename code style theme file #429

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

nnja
Copy link
Contributor

@nnja nnja commented Aug 10, 2020

There were two css files present containing themes for code styles:

  • static/css/hybrid.css
  • static/css/atom-one-dark-reasonable.css (actively used)

In this PR I:

  • removed the unused hybrid.css
  • removed references to hybrid.css
  • renamed the css file to the more reasonable code-style-theme.css

@McShelby
Copy link

From a CSS point of view hybrid.css is still loaded but its styles may be overwritten by atom-one-dark-reasonable.css. I am not quite sure if the later will redefine all of the previous styles.

Nevertheless, I think it's not a good idea to load two highlight.js styles in one html file. So deleting hybrid.css and all its references may be a good idea (it's also still in use in the `404.html')

The files shouldn't be renamed, because that's their official name in the official hightlight.js repo and therefore would hide their origin.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants