Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make the expand section more obvious #426

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

nnja
Copy link
Contributor

@nnja nnja commented Aug 9, 2020

From the interface it's pretty non-obvious that the expand section can actually be... expanded.

I added the following changes:

  • Add a mouse over to the title that's the same color as other links
  • Make the icons bigger, use a double chevron
  • Make the title bold
  • Indent the content slightly after it's expanded

Before (gif)

before

After (gif)

after

@matalo33 matalo33 added the enhancement Improvements to existing features label Sep 10, 2020
@matalo33
Copy link
Contributor

Thank you, I think this is a positive improvement. I think before merging it would be nice to enhance it a little further...

  • Text and button should be vertically centred. At the moment the text is lower as it aligns to the bottom of the div
  • Expand and no-expand buttons should be same horizontal width. When toggled the horizontal width reduces so the text heading shifts left. Can these be made to be the same width?

@matalo33 matalo33 added this to the v2.6.0 milestone Sep 10, 2020
@NicTanghe
Copy link

THe alignment of the arrows and text is verry weird.

i think a grey box -> (with the possibillity to change the colour) and a little arrow on the bot right would be better.

@McShelby
Copy link

McShelby commented Sep 12, 2020

  • I am not a fan of double chevrons. In other places single chevrons are used (prev, next and in some installations the sidebar menu expander). So for a coherent look I'ld prefer single chevrons.
  • I agree in changing the color to the same color that is used for links in general. This makes it obvious for the user, that this area is clickable.
  • I don't understand why the font needs to be strong. I think color is enough. Maybe it's an option to underline the text on MouseOver as with other links.
  • Also I have an idea why the icon is larger, I don't like it very much. It looks clumsy in its current form (this may be due to strange alignment with the text)

@JianLoong
Copy link
Contributor

I actually agree with @McShelby with regards to the usage of the single chevron instead of double.

A simple and old example of something old but nice would be jQueryUI accordion element. Link here

maxatome pushed a commit to maxatome/hugo-theme-learn that referenced this pull request Jan 23, 2024
maxatome pushed a commit to maxatome/hugo-theme-learn that referenced this pull request Jan 23, 2024
maxatome pushed a commit to maxatome/hugo-theme-learn that referenced this pull request Jan 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Improvements to existing features need user feedback
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants