-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Various Updates #237
Various Updates #237
Conversation
Add highlight.js theme Update theme to match highlight.js theme Update featherlight
highlightJS -> https://highlightjs.org/download/ => update with desired languages, default: https://cdnjs.cloudflare.com/ajax/libs/highlight.js/9.14.2/highlight.min.js modernizr -> https://modernizr.com/download/?csstransforms3d-domprefixes-prefixes-setclasses-shiv-testallprops-testprop-teststyles lunrJS -> https://cdnjs.cloudflare.com/ajax/libs/lunr.js/2.3.5/lunr.min.js clipboard -> https://cdnjs.cloudflare.com/ajax/libs/clipboard.js/2.0.4/clipboard.min.js jquery -> https://cdnjs.cloudflare.com/ajax/libs/jquery/3.3.1/jquery.min.js featherlight -> https://cdnjs.cloudflare.com/ajax/libs/featherlight/1.7.13/featherlight.min.js search.js -> updated for lunrJS 2.3.5 learn.js -> updated for clipboard
@matcornic is there any plan to merge this soon? Or provide feedback for changes? I believe this jQuery upgrade will resolve an XSS concern I currently have with my hugo site. |
fixed indent
fixed indent
This is a great PR. I hope to see this merged soon. |
This was held up because I wanted to quickly validate checksums of the javascript, however this has proven much more difficult than expected because a couple of the files come from dynamic generators. Here's what I found:
We don't really have a method for validating these files so I'll continue and merge for now. Maybe in the future dynamically generated JS shouldn't get supplied in PRs? On the other hand, if only maintainers could update dynamic JS files why should anyone trust that we haven't tampered with the JS? The end user should be able to md5 validate the files against upstream. Will give this some thought. In the meantime, thanks again for your extensive contribution! Apologies it took so long to merge. |
js
highlightJS -> https://highlightjs.org/download/ => update with desired languages, default: https://cdnjs.cloudflare.com/ajax/libs/highlight.js/9.14.2/highlight.min.js
modernizr -> https://modernizr.com/download/?csstransforms3d-domprefixes-prefixes-setclasses-shiv-testallprops-testprop-teststyles
lunrJS -> https://cdnjs.cloudflare.com/ajax/libs/lunr.js/2.3.5/lunr.min.js
clipboard -> https://cdnjs.cloudflare.com/ajax/libs/clipboard.js/2.0.4/clipboard.min.js
jquery -> https://cdnjs.cloudflare.com/ajax/libs/jquery/3.3.1/jquery.min.js
featherlight -> https://cdnjs.cloudflare.com/ajax/libs/featherlight/1.7.13/featherlight.min.js
search.js -> updated for lunrJS 2.3.5
learn.js -> updated for clipboard
css
Added highlight.js theme
Update theme.css to match highlight.js theme
Update featherlight.css