-
Notifications
You must be signed in to change notification settings - Fork 246
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add support for go modules #44
Conversation
Codecov Report
@@ Coverage Diff @@
## master #44 +/- ##
=======================================
Coverage 98.45% 98.45%
=======================================
Files 3 3
Lines 907 907
=======================================
Hits 893 893
Misses 8 8
Partials 6 6
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR, I will have to test everything next week.
Can you apply requested changed ?
Have a nice day :)
Would love to see this merged, it's giving me a lot of trouble in its current state. |
Is there something blocking this merge? For the moment I'm forced to do this in my go.mod: |
Hey,
I switched to go modules on my projects and because blackfriday is now supporting go modules too, I'm unable to use hermes because you are importing it with
gopkg.in
but blackfriday's module path isgithub.com
.To get the tests working, I switched from
gometalinter
togolangci-lint
.gometalinter
does not support go modules yet and it seems other popular projects are switching togolangci-lint
too.My current changes will only work for go 1.11+ projects, if you want we can check in the
vendor
directory generated bygo mod vendor
to support the versions below.