Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increased Test Coverage #701

Merged
merged 7 commits into from
Jul 17, 2024
Merged

Increased Test Coverage #701

merged 7 commits into from
Jul 17, 2024

Conversation

julianpollmann
Copy link
Collaborator

No description provided.

Copy link

@@ -61,8 +65,8 @@ def export_metadata_as_csv(spectra: List[Spectrum], filename: str,
Expected input is a list of :py:class:`~matchms.Spectrum.Spectrum` objects.
filename:
Provide filename to save metadata of spectrum(s) as csv file.
identifier:
Identifier used for naming each spectrum in the output file.
include_fields:
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch.

Copy link
Collaborator

@florian-huber florian-huber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks very good. Thanks a lot @julianpollmann !

@julianpollmann julianpollmann merged commit c488e21 into master Jul 17, 2024
16 of 17 checks passed
Copy link

@julianpollmann julianpollmann deleted the fix/increase_test_coverage branch July 22, 2024 14:42
Copy link

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants