Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove unnecessary warning #487

Merged
merged 5 commits into from
Aug 17, 2023
Merged

remove unnecessary warning #487

merged 5 commits into from
Aug 17, 2023

Conversation

florian-huber
Copy link
Collaborator

@florian-huber florian-huber commented Aug 16, 2023

This is just to remove an unnecessary warning currently happening if a precursor_mz value None is replaced by a new value.

@florian-huber florian-huber marked this pull request as ready for review August 17, 2023 07:41
@florian-huber
Copy link
Collaborator Author

florian-huber commented Aug 17, 2023

@hechth The CI run suddenly started to fail for all Windows runs and it seems to be related to issues with pep 517. Any ideas what's the matter here?

I am not yet familiar with the new poetry build, but it seemed related to this: python-poetry/poetry#7611

@florian-huber
Copy link
Collaborator Author

OK ... good exercise to get more used to poetry.
Running poetry update in a new environment seems to have fixed this.

@florian-huber florian-huber merged commit 5915236 into master Aug 17, 2023
@florian-huber florian-huber deleted the adjust_logging_level branch August 17, 2023 08:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant