Add tests for explicit "form" roles

#2 (comment)
matatk · Jun 2, 2019 · 9fc2bf4 · 9fc2bf4
1 parent 1fbae26
commit 9fc2bf4
Show file tree

Hide file tree

Showing 5 changed files with 55 additions and 0 deletions.
diff --git a/combined/expectations.json b/combined/expectations.json
@@ -267,6 +267,19 @@
       }
     ]
   },
+  "form-unlabelled-with-explicit-role": {
+    "meta": {
+      "name": "Form with no label, but an explicit role, is recognised"
+    },
+    "expected": [
+      {
+        "type": "landmark",
+        "role": "form",
+        "label": "null",
+        "selector": "body > div"
+      }
+    ]
+  },
   "header-containing-nav-nav-search": {
     "meta": {
       "name": "Header with nested landmarks, and others are recognised"
@@ -585,6 +598,12 @@
         "label": null,
         "selector": "#complementary",
         "contains": [
+          {
+            "type": "landmark",
+            "role": "form",
+            "label": null,
+            "selector": "#form"
+          },
           {
             "type": "landmark",
             "role": "search",

diff --git a/combined/fixtures.html b/combined/fixtures.html
@@ -184,6 +184,11 @@ <h1 id="form-heading">Report a Fault</h1>
 			<p>A form with a visible name for all folk!</p>
 		</form>
 	</div>
+<div data-test-id="form-unlabelled-with-explicit-role">
+		<div role="form">
+			<p>The form with no name, but an explicit role.</p>
+		</div>
+	</div>
 <div data-test-id="header-containing-nav-nav-search">
 		<header>
 			Page Header

diff --git a/expectations/form-unlabelled-with-explicit-role.json b/expectations/form-unlabelled-with-explicit-role.json
@@ -0,0 +1,13 @@
+{
+  "meta": {
+    "name": "Form with no label, but an explicit role, is recognised"
+  },
+  "expected": [
+    {
+      "type": "landmark",
+      "role": "form",
+      "label": "null",
+      "selector": "body > div"
+    }
+  ]
+}
diff --git a/expectations/roles-land.json b/expectations/roles-land.json
@@ -27,6 +27,12 @@
       "label": null,
       "selector": "#complementary",
       "contains": [
+        {
+          "type": "landmark",
+          "role": "form",
+          "label": null,
+          "selector": "#form"
+        },
         {
           "type": "landmark",
           "role": "search",

diff --git a/fixtures/form-unlabelled-with-explicit-role.html b/fixtures/form-unlabelled-with-explicit-role.html
@@ -0,0 +1,12 @@
+<!DOCTYPE html>
+<html lang="en">
+	<head>
+		<meta charset="UTF-8">
+		<title></title>
+	</head>
+	<body>
+		<div role="form">
+			<p>The form with no name, but an explicit role.</p>
+		</div>
+	</body>
+</html>