Skip to content

Commit

Permalink
Clarify when we are talking about form elements
Browse files Browse the repository at this point in the history
  • Loading branch information
matatk committed Jun 3, 2019
1 parent 272e43c commit 165876d
Show file tree
Hide file tree
Showing 4 changed files with 17 additions and 17 deletions.
24 changes: 12 additions & 12 deletions combined/expectations.json
Original file line number Diff line number Diff line change
Expand Up @@ -235,18 +235,6 @@
},
"expected": []
},
"form-alone-is-ignored": {
"meta": {
"name": "Unlabelled form is ignored",
"links": [
{
"url": "https://github.com/matatk/page-structural-semantics-scanner-tests/issues/2#issuecomment-497938545",
"text": "Overall info on forms and regions"
}
]
},
"expected": []
},
"form-aria-label": {
"meta": {
"name": "Form with aria-label is recognised",
Expand Down Expand Up @@ -285,6 +273,18 @@
}
]
},
"form-element-alone-is-ignored": {
"meta": {
"name": "Unlabelled form is ignored",
"links": [
{
"url": "https://github.com/matatk/page-structural-semantics-scanner-tests/issues/2#issuecomment-497938545",
"text": "Overall info on forms and regions"
}
]
},
"expected": []
},
"form-unlabelled-with-explicit-role": {
"meta": {
"name": "Form with no label, but an explicit role, is recognised",
Expand Down
10 changes: 5 additions & 5 deletions combined/fixtures.html
Original file line number Diff line number Diff line change
Expand Up @@ -168,11 +168,6 @@ <h2 id="head-appendix-b">Detailed schematics</h2>
</footer>
</blockquote>
</div>
<div data-test-id="form-alone-is-ignored">
<form action="blah">
<p>The form with no name.</p>
</form>
</div>
<div data-test-id="form-aria-label">
<form action="blah" aria-label="Contact Us">
<p>A form with a name.</p>
Expand All @@ -184,6 +179,11 @@ <h1 id="form-heading">Report a Fault</h1>
<p>A form with a visible name for all folk!</p>
</form>
</div>
<div data-test-id="form-element-alone-is-ignored">
<form action="blah">
<p>The form with no name.</p>
</form>
</div>
<div data-test-id="form-unlabelled-with-explicit-role">
<div role="form">
<p>The form with no name, but an explicit role.</p>
Expand Down
File renamed without changes.
File renamed without changes.

0 comments on commit 165876d

Please sign in to comment.