Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for the working-directory input + action check #4

Merged
merged 11 commits into from
May 5, 2020

Conversation

Jtalk
Copy link
Contributor

@Jtalk Jtalk commented Apr 22, 2020

Same as #3 + a validation pipeline. I wasn't sure if you want the pipeline in your repo, but I found it useful.

resolves #2

@matankdr
Copy link
Owner

matankdr commented May 5, 2020

@Jtalk, first I'm very sorry for the delay in my response (due to these crazy times 😃 ).
We will provide with faster response in the future.

Second, thank you (very!) much for your great code contribution.
CI is definitely welcomed 🚀🚀🚀

Thank you @kobi-lemberg for reviewing.

@matankdr matankdr merged commit cbbd7cd into matankdr:master May 5, 2020
@matankdr
Copy link
Owner

matankdr commented May 5, 2020

@Jtalk we are about to release a new version of this action containing your PR 🎉🎉🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add working-directory input
2 participants