svg lettericons #55
Merged
svg lettericons #55
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mat
approved these changes
Feb 28, 2021
besticon/iconserver/server_test.go
Outdated
| @@ -188,6 +201,21 @@ func TestGetLetterIcon(t *testing.T) { | |||
| assertIntegerInInterval(t, 1500, 1800, w.Body.Len()) | |||
| } | |||
|
|
|||
| func TestGetLetterIconSVG(t *testing.T) { | |||
| req, err := http.NewRequest("GET", "/lettericons/M-144-EFC25D.svg", nil) | |||
There was a problem hiding this comment.
Do we even want to allow for the size to be in the path for .svg? I'm thinking the fact the we allow it is kind of ok by Postel's law on the one hand but could lead to misunderstanding one the other (we're not using this).
There was a problem hiding this comment.
Sure, let's turn off support for size entirely. We're not generating those with SVG so no need to parse them. Give me a sec here
Comment on lines
+324
to
+327
| vars := map[string]string{ | ||
| "$BG_COLOR": ColorToHex(bgColor), | ||
| "$FG_COLOR": ColorToHex(pickForegroundColor(bgColor)), | ||
| "$LETTER": buf.String(), |
There was a problem hiding this comment.
Like the lightweight templating approach for this👍
|
OK, check out the latest commit. I reworked |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The server can generate SVG lettericons. Only enabled if
?formats=includessvg. Most of the action is inRenderSVG. Also tweaks toIconPathto support SVG. For example, an SVG lettericon path doesn't include the size in the filename.One thing to note. The A-Z lettericons look great (see below), but ф is a bit low. Right now we have
dy="0.10em"hardcoded in the SVG template. Not sure if it would be possible/worthwhile to customize based on the letter. I could also imagine using Freetype to measure the Arial glyph height... The traco 1M doesn't include any IDN domains, unfortunately.