correct logic in perfect..min size search #30
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I believe I found the error in your logic for determining the correct min size. You have a comment there that describes what you wanted, but the logic did not match.
The current code does not compare against the max or perfect range when searching for the biggest icon that is
>
min. Since the icons are sorted in descending order for this iterator, you will always get the largest icon from the list (which is the first one in the for loop). This confirms the behavior I am seeing in #28.Note: I am not a go developer and I was not able to run and test this code. I do, however, know how to read boolean logic 😃 . Please double check my work and syntax (I just copy/pasted and tweaked from the above logic).
resolves #28