Add fallback_icon_color query parameter to API. #14
Conversation
If provided in the query parameters, this will use a hash of the URL passed in to color the letter icon used. The color is used when there is no icon of the requested size, and no "main color" could be found in smaller icons. The idea is that this will prevent so many icons being grey when a large icon size is requested.
|
Hey @mmkal first of all thanks for your work! While I find the idea interesting I don't believe it's the right approach to fix the (annoying) issue which is the grey icons: Having some background color for the sake of having a colorful icon is not really the goal of extracting the 'main color' from other existing icons. The goal is to resemble the actual favicon at least in terms of color. This is not at all the case with randomized colors. That said, I definitely can see the value of setting another fallback color as grey - for users like you who prefer randomized colors or for users who want the fallback color be more fitting to the rest of their UI. My proposal: Instead of a What do you think? |
|
That's a great idea actually - I can just pass in my arbitrary colour as a query parameter, and if it doesn't get used because your colour finder was able to parse a smaller icon, so much the better. I could update this pull request to do that instead? |
|
Of course, please, give it a shot 😃👍 |
This allows clients to pass in a hex value as a fallback letter color.
(used ? when it should have been &)
mmkal
changed the title
|
Thank you! From a quick view this looks almost exactly like how I would've done it 😀 But please give me the time to have a closer look on Sunday hopefully... Please feel free to add yourself to the Contributors section in the Readme in the meantime. |
| redirectPath := lettericon.IconPath(letter, size, iconColor) | ||
|
|
| @@ -28,6 +28,7 @@ url | http://yelp.com | | required | |||
| size | 120 | Desired **minimum** icon size | required | |||
| formats | png,ico | Comma-separated list of accepted image formats: png, ico, gif | `png,ico,gif` | |||
| fallback\_icon\_url | *HTTP image URL* | If provided, a redirect to this image will be returned in case no suitable icon could be found. This overrides the default fallback image behaviour. | | |||
| fallback\_icon\_color | ff0000 | If provided, letter icons will be colored with the hex value provided, rather than be grey, when no color can be found for any icon. | |||
There was a problem hiding this comment.
Is ff0000 really the actual grey in use? (I honestly don't know)
There was a problem hiding this comment.
Ah, sorry, this is an example value, not the default. So, disregard.
There was a problem hiding this comment.
See below - ff0000 is bright red 
rgb(255, 0, 0)) so should make it visually pretty obvious what it does, especially when contrasted with the line above. Not sure what the deployment story is, but it should be easily visible if these changes go in and the server is updated.
| @@ -38,6 +39,7 @@ fallback\_icon\_url | *HTTP image URL* | If provided, a redirect to th | |||
| |<https://icons.better-idea.org/icon?url=yelp.com&size=64>|| | |||
| |<https://icons.better-idea.org/icon?url=yelp.com>|size missing| | |||
| |<https://icons.better-idea.org/icon?url=httpbin.org/status/404&size=64>|| | |||
| |<https://icons.better-idea.org/icon?url=httpbin.org/status/404&size=64&fallback_icon_color=ff0000>|| | |||
There was a problem hiding this comment.
Why not use a nice, more colorful background color as example which is different from the default to make it even more obvious what this param is for?
There was a problem hiding this comment.
Yep, I had the same thought - ff0000 is bright red!
|
Thanks for your contribution @mmkal, much appreciated! |
|
No problem - thank you for taking it in, I'm using it now and my page is looking great! |
If provided in the query parameters, this will use a hash of the URL passed in to color the letter icon used. The color is used when there is no icon of the requested size, and no "main color" could be found in smaller icons.
The idea is that this will prevent so many icons being grey when a large icon size is requested.