-
-
Notifications
You must be signed in to change notification settings - Fork 7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace more font-awesome
icons in views/admin
area
#30961
Conversation
font-awesome
icons in views/admin
area
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not a fan of the power
/power_off
icons for the custom emoji but I can't really think of fitting icons. Very minor alignment issue in report interface with the new skip icon.
Otherwise this looks good to me.
Alignment looks weird, especially with the hourglass icon. I am not sure where it comes from, but it should be a simple CSS fix? Should this be something done for every material icon, to match FA's behaviour? |
I just noticed in the existing fa icons they're the same "power off" -- so at least this is an improvement. |
29e57cb
to
ce9d604
Compare
Yeah, presumably there is slightly different padding in the svg between some of the material vs FA icons, and that leads to some of these different alignment issues. My plan was to attempt to get them all replaced first in a "good enough, not outright broken" way, and then do another refinements pass wherever there are alignment/padding/whatever issues. |
There is a "Power Settings New" icon in material that is basically the same as current FA power off, but it seems like we should correct the "enable and disable are using the same icon" thing while we're in here, and there's not really an "opposite" of that one. There are "toggle on" and "toggle off" in material which are almost meaningless but at least are different than each other ... could switch to that or something else instead of power/power_off. |
I think the toggles next to each other aren't really helpful if they don't actually toggle, as a single item individually. Just visually it doesn't make sense to me. |
ce9d604
to
4334d28
Compare
Switched to use a radio button checked/unchecked icon instead. Strikes me as marginally better than power options, and an improvement over the current same-icon state of things. We're not there yet - but I want to avoid bikeshedding to exact perfection here; would strongly prefer to get a "good enough" pass at replacement, and then continue to refine/replace/restyle/etc in advance of release but after we fully remove FA. |
4334d28
to
fb7880a
Compare
fb7880a
to
7805298
Compare
Followup on #29612 and #27780
This one handles the rest of the app/views/admin area that was not already handled. Like the previous one, I tried to use as close to a 1:1 mapping as there was, which sometimes had same name and other times did not. Also like last time, there is some small wiggle in the exact positioning.
Some before/after (not exhaustive, but representative):