Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automatically switch from open to approved registrations in absence of moderators #29318

Merged
merged 4 commits into from
Feb 21, 2024

Conversation

ClearlyClaire
Copy link
Contributor

@ClearlyClaire ClearlyClaire commented Feb 21, 2024

This is not meant to replace #29280, but supplement it to avoid unmonitored servers keeping open registrations indefinitely.

Automatically switch away from open registrations if no user with the permission to view reports has had any activity (authenticated request to the server) in over a week.

Can be disabled with the DISABLE_AUTOMATIC_SWITCHING_TO_APPROVED_REGISTRATIONS environment variable if you are for instance using external tools for moderation. It's also disabled when using an email domain allow-list (EMAIL_DOMAIN_ALLOWLIST).

@ClearlyClaire ClearlyClaire force-pushed the features/auto-close-registrations branch from aecf335 to 85ebd78 Compare February 21, 2024 14:21
@ClearlyClaire ClearlyClaire marked this pull request as ready for review February 21, 2024 14:23
@ClearlyClaire ClearlyClaire force-pushed the features/auto-close-registrations branch 2 times, most recently from 5383b86 to b4a16b9 Compare February 21, 2024 14:44
@ClearlyClaire ClearlyClaire added the to backport PR needed to be backported label Feb 21, 2024
@ClearlyClaire ClearlyClaire requested a review from a team February 21, 2024 15:12
Copy link
Member

@renchap renchap left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good except the comment I left.

We probably need a documentation update for the new ENV variable, and maybe a note about this behaviour somewhere in the docs?

@ClearlyClaire ClearlyClaire force-pushed the features/auto-close-registrations branch from b4a16b9 to 9f0f16d Compare February 21, 2024 15:25
@ClearlyClaire ClearlyClaire requested a review from a team February 21, 2024 16:47
Gargron
Gargron previously approved these changes Feb 21, 2024
config/locales/en.yml Outdated Show resolved Hide resolved
@Gargron Gargron enabled auto-merge February 21, 2024 17:45
@Gargron Gargron added this pull request to the merge queue Feb 21, 2024
Merged via the queue into main with commit 2751acb Feb 21, 2024
41 checks passed
@Gargron Gargron deleted the features/auto-close-registrations branch February 21, 2024 17:50
ClearlyClaire added a commit to ClearlyClaire/mastodon that referenced this pull request Feb 22, 2024
ClearlyClaire added a commit to glitch-soc/mastodon that referenced this pull request Feb 22, 2024
kmycode pushed a commit to kmycode/mastodon that referenced this pull request Feb 23, 2024
@bbtuxi
Copy link

bbtuxi commented Feb 25, 2024

I would rather set the period to 24 hours.
One week is far too long.

fad0805 pushed a commit to fad0805/daydream.ink that referenced this pull request Feb 26, 2024
skerit pushed a commit to 11ways/mastodon that referenced this pull request Feb 27, 2024
Ember-ruby pushed a commit to Ember-ruby/mastodon-glitch that referenced this pull request Mar 19, 2024
@ClearlyClaire ClearlyClaire removed the to backport PR needed to be backported label May 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants