-
-
Notifications
You must be signed in to change notification settings - Fork 7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Show comments in the admin/instances page #29240
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #29240 +/- ##
==========================================
+ Coverage 85.01% 85.10% +0.08%
==========================================
Files 1059 1062 +3
Lines 28277 28352 +75
Branches 4538 4548 +10
==========================================
+ Hits 24040 24129 +89
+ Misses 3074 3061 -13
+ Partials 1163 1162 -1 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, I think so! Although I'm slightly worried about space, but that's a minor issue. I'd also probably omit the line rather than write “None Found”. |
Thank you for comments. I'll change as you guide |
f2086ee
to
7150ffd
Compare
Co-authored-by: Claire <[email protected]>
Co-authored-by: Claire <[email protected]>
Co-authored-by: Claire <[email protected]>
We have lots of spaces on admin/instances page. Show internal, public comment will be useful when managing instance blocks