Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show comments in the admin/instances page #29240

Merged
merged 4 commits into from
Feb 28, 2024

Conversation

tribela
Copy link
Contributor

@tribela tribela commented Feb 16, 2024

We have lots of spaces on admin/instances page. Show internal, public comment will be useful when managing instance blocks
image

Copy link

codecov bot commented Feb 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.10%. Comparing base (86500e3) to head (62d4a75).
Report is 177 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #29240      +/-   ##
==========================================
+ Coverage   85.01%   85.10%   +0.08%     
==========================================
  Files        1059     1062       +3     
  Lines       28277    28352      +75     
  Branches     4538     4548      +10     
==========================================
+ Hits        24040    24129      +89     
+ Misses       3074     3061      -13     
+ Partials     1163     1162       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@ClearlyClaire ClearlyClaire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi! Thank you for your contribution! Unfortunately, I think it looks unclear that those are the public and private comments you set. Additionally, I think they lack separators. Finally, I'm afraid long descriptions are going to cause issues with limited width layouts:
image

app/views/admin/instances/_instance.html.haml Outdated Show resolved Hide resolved
@jazmichaelking
Copy link

Would something like this be more useful:

image

@ClearlyClaire
Copy link
Contributor

Yeah, I think so! Although I'm slightly worried about space, but that's a minor issue. I'd also probably omit the line rather than write “None Found”.

@tribela
Copy link
Contributor Author

tribela commented Feb 26, 2024

Thank you for comments. I'll change as you guide

@tribela
Copy link
Contributor Author

tribela commented Feb 27, 2024

image

@tribela tribela force-pushed the admin-instances-comment branch from f2086ee to 7150ffd Compare February 27, 2024 04:02
@ClearlyClaire ClearlyClaire added this pull request to the merge queue Feb 28, 2024
Merged via the queue into mastodon:main with commit deffb8e Feb 28, 2024
28 checks passed
@tribela tribela deleted the admin-instances-comment branch February 29, 2024 07:03
lutoma pushed a commit to ohaisocial/mastodon that referenced this pull request Mar 19, 2024
Ember-ruby pushed a commit to Ember-ruby/mastodon-glitch that referenced this pull request Apr 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants