Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change min. password length from 8 to 12 #24703

Closed
wants to merge 1 commit into from

Conversation

Gargron
Copy link
Member

@Gargron Gargron commented Apr 28, 2023

No description provided.

@Gargron Gargron force-pushed the fix-raise-min-password-length branch 2 times, most recently from 1f38a94 to d026810 Compare April 28, 2023 05:48
Copy link
Contributor

@ThisIsMissEm ThisIsMissEm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

I did also look to see if this may effect the change password settings screen, and but it's fine as there is no password min/max length on the "current password" field. (if it were inheriting the min-length from the model, then we'd have to hardcode to 8 instead of 12, otherwise people wouldn't be able to change their passwords without first resetting them).

Looking at the tests, there doesn't seem to be a specific test (integration perhaps) that the current/new password form (/auth/edit) submits correctly (unless this is handle in devise in someway?)

@github-actions
Copy link
Contributor

github-actions bot commented May 4, 2023

This pull request has merge conflicts that must be resolved before it can be merged.

@renchap
Copy link
Member

renchap commented May 19, 2023

This may be a good start, but I think this should be part of a wider initiative around how passwords are handled:

@github-actions
Copy link
Contributor

github-actions bot commented Jun 6, 2023

This pull request has resolved merge conflicts and is ready for review.

@Gargron Gargron force-pushed the fix-raise-min-password-length branch from ca58da2 to 6989518 Compare June 6, 2023 03:56
@Gargron Gargron closed this Aug 10, 2023
@Gargron Gargron deleted the fix-raise-min-password-length branch August 10, 2023 23:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants