Show spinner while loading follow requests

[c960657]

When clicking on Follow requests in the context menu above the compose form, I see a brief flash of the “Even though your account is not locked …” message instead of a loading spinner.

[ClearlyClaire]

Sounds like a sensible change to me, although I'm unsure of how the “Even though your account is not locked” message would appear only while loading. Did I misunderstand that part?

[c960657]

If the list is empty after loading is complete, the prepend block is only shown if alwaysPrepend is specified, and it isn't for this list.

[ClearlyClaire]

But it should only show up if you either have a non-empty list or have a locked account, right?

[c960657]

It should show up if your account is unlocked and the are pending follow requests.

But currently is shows up if your account is unlocked, even if there are no follow requests (but only while loading).

Perhaps it is worth changing ScrollableList so that prepend is never shown while loading, if there is an emptyMessage (unless alwaysPrepend is specified). This will prevent the short flash of prepend for all lists with prepend+emptyMessage, and will allow to remove my check for accountIds.size in the unlockedPrependMessage assignment.

     if (showLoading) {
       scrollableArea = (
         <div className='scrollable scrollable--flex' ref={this.setRef}>
           <div role='feed' className='item-list'>
-            {prepend}
+            {(!emptyMessage || alwaysPrepend) && prepend}
           </div>

[ClearlyClaire]

But currently is shows up if your account is unlocked, even if there are no follow requests (but only while loading).

I mean, the option to navigate to follow requests should not even be there in such a case.