Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix status updates not being forwarded like deletes through ActivityPub #17648

Merged
merged 1 commit into from
Feb 26, 2022
Merged

Fix status updates not being forwarded like deletes through ActivityPub #17648

merged 1 commit into from
Feb 26, 2022

Conversation

Gargron
Copy link
Member

@Gargron Gargron commented Feb 25, 2022

Fix #17521

ClearlyClaire
ClearlyClaire approved these changes Feb 26, 2022
View reviewed changes
Copy link
Contributor

@ClearlyClaire ClearlyClaire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

We still have to take care of Update activities when AUTHORIZED_FETCH_MODE is enabled. Signing the Update but without inlining the object should work, although inefficiently.

@Gargron Gargron merged commit 0dc57ab into main Feb 26, 2022
@Gargron Gargron deleted the fix-forward-updates branch February 26, 2022 16:52
@arittner arittner mentioned this pull request Jun 20, 2022
Closed
@ahox ahox mentioned this pull request Nov 25, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ClearlyClaire ClearlyClaire ClearlyClaire approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Post edition] Update activities are not forwarded
2 participants
@Gargron @ClearlyClaire