Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add import/export feature for bookmarks #14956

Merged

Conversation

ClearlyClaire
Copy link
Contributor

@ClearlyClaire ClearlyClaire commented Oct 7, 2020

No description provided.

@ClearlyClaire ClearlyClaire force-pushed the features/bookmarks-import-export branch 9 times, most recently from bb90f26 to 3f9c3d4 Compare October 8, 2020 16:22
@ClearlyClaire ClearlyClaire force-pushed the features/bookmarks-import-export branch from 3f9c3d4 to b045f0f Compare October 8, 2020 18:36
@ClearlyClaire ClearlyClaire marked this pull request as ready for review October 8, 2020 19:28
@ClearlyClaire ClearlyClaire requested a review from Gargron October 9, 2020 12:46
@ClearlyClaire
Copy link
Contributor Author

@Gargron ping?

@umonaca
Copy link
Contributor

umonaca commented Nov 6, 2020

I think it's useful for me since I have multiple accounts across different instances. It's a headache for me to look up for a certain toot that I bookmarked, since not all instances like Elasticsearch -- they have set their "search toot" functionality to disabled.

@Gargron Gargron merged commit 96c1e71 into mastodon:master Nov 19, 2020
Gargron pushed a commit that referenced this pull request Mar 15, 2021
The exports page showed a different "CSV" capitalisation in the
"Bookmarks" row ("Csv") compared to the other rows ("CSV").
This was due to a referece to a translation string that does not exist,
`bookmarks.csv`, defaulting to the key's last segment in title case.

This issue was introduced in commit dcd8620 (PR #14956).

(h/t @meqif for helping with figuring out the bug)
chrisguida pushed a commit to Start9Labs/mastodon that referenced this pull request Feb 26, 2022
…don#15894)

The exports page showed a different "CSV" capitalisation in the
"Bookmarks" row ("Csv") compared to the other rows ("CSV").
This was due to a referece to a translation string that does not exist,
`bookmarks.csv`, defaulting to the key's last segment in title case.

This issue was introduced in commit dcd8620 (PR mastodon#14956).

(h/t @meqif for helping with figuring out the bug)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants