Fix serialization of replies when some of them are URIs #13957
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ClearlyClaire
force-pushed
the
fixes/mix-uri-inlined-objects
branch
5 times, most recently
from
e055c2a to
0dccf04
Compare
ClearlyClaire
force-pushed
the
fixes/mix-uri-inlined-objects
branch
from
0dccf04 to
0321019
Compare
Gargron
approved these changes
Jun 4, 2020
shouo1987
pushed a commit
to CrossGate-Pawoo/mastodon
that referenced
this pull request
Dec 7, 2022
* Fix serialization of replies when some of them are URIs Fixes mastodon#13956 * Add test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #13956
This happens because Active Model Serializer's
CollectionSerializer(automatically used for arrays) does not allow mixing primitives (such as strings, like the URIs here) and raises:no_serializerwhenever one of the items is a primitive, making the whole thing fall back toto_json.This PR introduces a
StringSerializerto allow mixing strings with serializable objects. This messes a bit with the fact that AMS serializers are geared towards rendering actual JSON object, but that was already the case of the built-inActiveModel::Serializer::CollectionSerializer.