Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix regression in sparkline style in web UI #13753

Merged
merged 1 commit into from
May 14, 2020
Merged

Fix regression in sparkline style in web UI #13753

merged 1 commit into from
May 14, 2020

Conversation

Gargron
Copy link
Member

@Gargron Gargron commented May 14, 2020

Most likely a regression from #13679

@Gargron Gargron added the bug Something isn't working label May 14, 2020
@Gargron Gargron merged commit c9dcc2d into master May 14, 2020
@Gargron Gargron deleted the fix-sparkline-css branch May 14, 2020 07:01
@ClearlyClaire
Copy link
Contributor

Oh, react-sparklines does indeed use inline CSS quite a bit… sorry I have missed that… this fix is fine, but sparklines will still generate a lot of warnings in the browser's console. I will see if something can be done upstream to avoid that.

@ClearlyClaire
Copy link
Contributor

react and react-sparklines are actually doing what they should, it is a Firefox bug, see https://bugzilla.mozilla.org/show_bug.cgi?id=1637954

@olivievranska olivievranska mentioned this pull request Nov 8, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ykzts ykzts ykzts approved these changes

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Gargron @ClearlyClaire @ykzts