Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Twemoji to 12.1.5 #13021

Merged
merged 2 commits into from
Apr 19, 2020
Merged

Conversation

DeeUnderscore
Copy link
Contributor

Twemoji

This updates Twemoji with the SVGs from the Twemoji repo at v12.1.5.

Previous version in Mastodon was 12.1.3, so the most noticeable change with this one is the inclusion of gender-inclusive/gender-neutral designs, so that you'll see a difference between, for example, 🙋 without gender modifiers and 🙋‍♀️, with gender modifier (you won't see that difference here on the Github website).

emoji_map.json was also updated to Unicode 12, from 11.

Emoji picker

I did not update the emoji picker, as that's an external dependency. While the spritesheet that the picker uses is distributed in this repo, the data for the picker comes with the picker package (Gargron/emoji-mart).

New data could be grabbed from the upstream emoji-mart repo, while new sheets could be grabbed from iamcal/emoji-data, which is what emoji-mart uses.

This is something that should probably be eventually updated, especially after the Unicode 13 release and subsequent Twemoji updates, which will happen sometime starting in March.

@moritzheiber
Copy link
Member

I just noticed Mastodon doesn't have gender-neutral emoji yet .. which even the iPhone has now. How about merging this?

@Gargron
Copy link
Member

Gargron commented Apr 19, 2020

Okay, I reproduced all changes, all clean.

@Gargron Gargron merged commit 29f5353 into mastodon:master Apr 19, 2020
@DeeUnderscore DeeUnderscore deleted the twemoji-update branch May 21, 2020 16:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants